[Kde-pim] Review Request 123561: kolabchanges: messageviewer [3/4]

[Sandro Knauß]

> On April 29, 2015, 12:22 nachm., Laurent Montel wrote:
> > messageviewer/viewer/viewer_p.cpp, line 3395
> > <https://git.reviewboard.kde.org/r/123561/diff/1/?file=364440#file364440line3395>
> >
> >     Are you sure that it compiles ?
> >     qCDebug()

No. I compiled it once with all patches, but because I split it to many reviews sometimes there get errors into it. In the end if the review is accepted I compile it another time to make sure, that master is buildable.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123561/#review79672
-----------------------------------------------------------


On April 30, 2015, 9:57 vorm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123561/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 9:57 vorm.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/viewer.h 40ae9fca3f8d03e9f35ded95923fdf8b1b84fc02 
>   messageviewer/viewer/viewer.cpp 399aacf9818ad8ae823b2bee4768b3b8b863bb55 
>   messageviewer/viewer/viewer_p.h c6e579b2d998f1a86526c38779b4be9be94b9817 
>   messageviewer/viewer/viewer_p.cpp fe76710822057599b94ec1a9b4e2366478c855bf 
> 
> Diff: https://git.reviewboard.kde.org/r/123561/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/