[Kde-pim] Review Request 123522: kolab changes: calenderviews

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123522/#review79669
-----------------------------------------------------------



calendarviews/agenda/agendaview.cpp (line 2028)
<https://git.reviewboard.kde.org/r/123522/#comment54490>

    qCCritical(...)



calendarviews/agenda/viewcalendar.h (line 60)
<https://git.reviewboard.kde.org/r/123522/#comment54491>

    Remove all virtual keyword. Q_DECL_OVERRIDE is enough.



calendarviews/agenda/viewcalendar.cpp (line 165)
<https://git.reviewboard.kde.org/r/123522/#comment54492>

    qCWarnig(...)...



calendarviews/month/monthscene.h (line 223)
<https://git.reviewboard.kde.org/r/123522/#comment54493>

    Q_DECL_OVERRIDE + remove virtual



calendarviews/todo/todoview.cpp (line 391)
<https://git.reviewboard.kde.org/r/123522/#comment54494>

    QStringLiteral where necessary


- Laurent Montel


On avr. 29, 2015, 11:42 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123522/
> -----------------------------------------------------------
> 
> (Updated avr. 29, 2015, 11:42 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create todo/note out of month view
> * MonthView: Generate the tooltip-text on demand.
> 
> This used to be a major bottleneck because generating the tooltip was relatively
> expensive, and generated for every event (which is pointless).
> 
> * CalendarViews: show color for parent Collection
> * default color of subcalendars same as the person folder
> * Agendaview: get rid of akonadi items
> 
> replace Akonadi::Items with Incidence::Ptr to make Agandaview
> independend of Akonadi to use it also in other circusstances like the
> quickview or the resourceview.
> 
> 
> Diffs
> -----
> 
>   calendarviews/CMakeLists.txt e0bcf110f1790698fbe1b5dc88e7a40443bea99e 
>   calendarviews/agenda/agenda.h 20fb91e64190203bf4d15eba7da26fa02cbbd013 
>   calendarviews/agenda/agenda.cpp d5c18b0ba1c6129c1ce837f85141fcada86acc87 
>   calendarviews/agenda/agendaitem.h 79be83b2417aac5a4e3efeee4cf8b9e41f56c1c2 
>   calendarviews/agenda/agendaitem.cpp c5d3c186bfc9ef8c266f1620c91852cab007f9b1 
>   calendarviews/agenda/agendaview.h 0a07dbd14bab60f7d4477c96d73d462d030d9694 
>   calendarviews/agenda/agendaview.cpp d6705ca8df9e92d7774c96a5278fe898877e1423 
>   calendarviews/agenda/viewcalendar.h PRE-CREATION 
>   calendarviews/agenda/viewcalendar.cpp PRE-CREATION 
>   calendarviews/eventview.h a7496590f3cee46af7e36bbdcc5e110670f19854 
>   calendarviews/helper.cpp 59238336214cd8b1bf5c7d2741a5e2d212cf4d05 
>   calendarviews/month/monthgraphicsitems.h 59570892d757d950f9af0f9e2e60ab248bfbf8c5 
>   calendarviews/month/monthgraphicsitems.cpp 1879261ad9b0e827385d33db2271c1e82a3fa3e8 
>   calendarviews/month/monthitem.cpp af652922f377d246986d06b3130d950ad2c8b50e 
>   calendarviews/month/monthscene.h 9211f5fb14f419f8904db04f5b1e9efa47e57c4a 
>   calendarviews/month/monthscene.cpp f592e03efd86894eed4e0edbb741d2affe059cab 
>   calendarviews/prefs.h 2f676c709d8f3aca94f45926d16522a24245a35c 
>   calendarviews/prefs.cpp b9730b4f6a9de088a2706779d2d0f0a5f490d4bc 
>   calendarviews/todo/todoview.h b8a3261f53a12d35597964eb5cfda66e010c80bd 
>   calendarviews/todo/todoview.cpp d94a3b8597a893621c0cc450cba2457e5395ef14 
>   korganizer/kohelper.h 66c4bd2c560f3db8fd22a46e2a9ee4a4a37a30f3 
>   korganizer/kohelper.cpp e1fe20332d9904a4098611a4098827c6937a9075 
> 
> Diff: https://git.reviewboard.kde.org/r/123522/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/