[Kde-pim] Review Request 123574: kolabchanges: kmail

[Laurent Montel]

> On avr. 30, 2015, 4:34 après-midi, Laurent Montel wrote:
> > kmail/CMakeLists.txt, line 173
> > <https://git.reviewboard.kde.org/r/123574/diff/1/?file=365262#file365262line173>
> >
> >     As I wrote in other patch I am against to remove this dialogbox.
> >     With akonadi dialog box we can't specify kmail tag which has shortcut/color etc.
> >     So This patch will not add to kmail.
> 
> Sandro Knauß wrote:
>     Having different tagselectiondialogs in kdepim is also a mess.
>     I would argue if the one in Akonadi has not the needed featueres we should extend this and not create a copy.

So extend it :)
But for the moment kmail will keep its dialogbox.


> On avr. 30, 2015, 4:34 après-midi, Laurent Montel wrote:
> > kmail/kmcommands.cpp, line 1292
> > <https://git.reviewboard.kde.org/r/123574/diff/1/?file=365264#file365264line1292>
> >
> >     I am against remove it.
> >     I implemented it because we can have a lot of tag and I decided to show just specific tag that we already used.
> >     It will not apply to kmail.
> 
> Sandro Knauß wrote:
>     The problem here there is a usecase behind it:
>     
>     * A user adds a tag at the webmailer
>     * kontact is synced
>     * user like to see the attached tag to the mail
>     
>     At the moment he would only see this, if we has used the tag in the past. Not a good UX.
>     
>     also storingthetags in a string in configfile is not good too, because you do not get the information if a tag is deleted.
>     Than you end up with tags in configfile, that are not exist anymore.

And I have an other user case.
An user create x tag in kaddreebook for contact and he doesn't want see them in kmail.
So he will see just tag which he used in kmail.


But indeed perhaps there is a bug which doesn't delete tag in configfile but it can be fixed.

Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123574/#review79736
-----------------------------------------------------------


On avr. 30, 2015, 4:24 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123574/
> -----------------------------------------------------------
> 
> (Updated avr. 30, 2015, 4:24 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * Check out of office status after the sieve editor is closed.
> * Use Akonadi::TagSelectionDialog instead of homebrew dialog.
> * messagelist: show complete taglist in tag combobox.
> * Showing "Create Note" entry.
> 
> 
> Diffs
> -----
> 
>   kmail/CMakeLists.txt 593c847cff2606a65790d1c7d34ad05221779462 
>   kmail/kmail_part.rc 93d2c88090071d4087584936c551aae7d1c3c131 
>   kmail/kmcommands.cpp 563ff7853934725eed3295911ab684850d8c9b0d 
>   kmail/kmmainwidget.cpp 20ecca9414eff7a50133e1cdd221d098d40aa34b 
>   kmail/kmmainwin.rc db3c27b082bf3e7d94b86e583db317acc92bcd64 
>   kmail/kmreaderwin.h becab7b33287ebca807e6d454f92339212570c8a 
>   kmail/kmreaderwin.cpp c7db2569cc4d6fb0f658f6a032e19067dd892199 
>   kmail/tag/tagselectdialog.h 1886d0b75bf2b4f9f0ef5fc1e88603509d6ee188 
>   kmail/tag/tagselectdialog.cpp 74b18b9907e10ed37127af66c784485edf03dac4 
>   messagelist/core/settings.kcfg 5215a1fc00e62579b2a07a4fa0e5b45c35f2f582 
>   messagelist/widget.cpp 5dbbfa4ec5d820598f589a9b21666e408193bb59 
> 
> Diff: https://git.reviewboard.kde.org/r/123574/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/