[Kde-pim] Review Request 123373: akonadi-calendaring patches from kolab branch
Christian Mollekopf
chrigi_1 at fastmail.fm
Fri Apr 17 09:54:03 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123373/
-----------------------------------------------------------
(Updated April 17, 2015, 8:54 a.m.)
Review request for KDEPIM-Libraries and Laurent Montel.
Changes
-------
adressed all comments
Repository: akonadi-calendar
Description
-------
various compile fixes
moved calfilterpartstatusproxymodel to it's proper place
some small cleanups
Conflicts:
src/incidencechanger.cpp
Only alarm modifications should not trigger a out-of-sync event
Users should be able to set their own alarm settings for events without
triggering a out-of-sync dialog.
KOLAB #1386
Conflicts:
src/incidencechanger.cpp
rescedule event triggers attendee status to NEEDS-ACTION
If an event is resceduled ( date or location) all attendees should be
ask again, for there status. Therefore the partStatus should be set back
to NEEDS-ACTION
KOLAB: #4533
Conflicts:
autotests/incidencechangertest.cpp
BlockAlarmAttribute: All methods to set/read all types
BlockAlarmAttribute is used mostly as a everything enabled/disabled. So
make the interface easier to use it this way.
KOLAB: #3731
Conflicts:
src/blockalarmsattribute.h
src/etmcalendar.cpp
Make it possible to show only a subtree as calendar
Kolab: #3054
Conflicts:
src/etmcalendar.h
Fixed build.
Conflicts:
src/calendarbase.cpp
calfilterpartstatusproxy: alendarUtilits::incidence
(merge with fd0b82b0 for kdepimlibs master)
Akonadi::Calendar: Using CalendarUtilits::incidence
this is ~twices as fast as using hasPayload + payload
Conflicts:
src/calendarmodel.cpp
src/calfilterproxymodel_p.cpp
Filter out new invitatins and declined events from etmcalendar.
invitations and declined events are available over a search collection,
so we don't want to show them in normal calendars.
Kolab: #3549
Conflicts:
CMakeLists.txt
src/etmcalendar.cpp
Used cached version of thatIsMe and allEmails
Conflicts:
src/utils_p.cpp
Postpose button for invitations
* show postpone button
* handle postpone -> only store event in calendar
* add test for postpone
Conflicts:
src/scheduler_p.cpp
ReadOnly is read from storageCollection
Conflicts:
src/calendarbase.cpp
src/calendarbase_p.h
src/fetchjobcalendar.cpp
New standard action to synchronize the collection tree.
Diffs (updated)
-----
autotests/etmcalendartest.h 4e3003e3d20ce472e8e0ce7341e5b079442af55b
autotests/etmcalendartest.cpp 0ed5c0506152322de9d6123be02b67ca2f683cf0
autotests/incidencechangertest.cpp 206934dd32e716dc2f73fbc1f1a2fea0061fd064
autotests/itiphandlertest.cpp 0b0b832a148054e92ece18e4a8ed1203c32fd8d6
src/CMakeLists.txt 9f697ef89f932fe5ec909976f26b65e8c045e881
src/blockalarmsattribute.h 75c043149891adf216003d236a82f8d7b95bb517
src/blockalarmsattribute.cpp b64fc7774e87722d6ae1cb078a7f598584d8642a
src/calendarbase.cpp 67e8d054b355e7252ab1f811e72f316641af63dd
src/calendarbase_p.h 138d73091d31c367c741a674386146bc6f9f5915
src/calendarmodel.cpp ed47f22599fff710ad4bc7c7a09a2dfa5ae7d7bb
src/calfilterpartstatusproxymodel_p.h PRE-CREATION
src/calfilterpartstatusproxymodel_p.cpp PRE-CREATION
src/calfilterproxymodel_p.cpp 15baf758d078cdc5e21c296cffc03aa385bd79da
src/etmcalendar.h e391ef7e26de080e84bc16a58dd21774ac104971
src/etmcalendar.cpp 92b70022fc803e4bdc0f8fb5c446f2d9dc790771
src/etmcalendar_p.h 85f10e3b30f2f385e94b6e93334f3a05a5955983
src/fetchjobcalendar.cpp 24d107a47950a898913412440e56c3a176e33099
src/fetchjobcalendar_p.h 9c7a4338ed5596f6c6e3641cd376fa286e07dc35
src/incidencechanger.cpp 1604369dfe10de4bb82544447f1163ffa0ee16ee
src/itiphandler.cpp 2ec326fcbfb03b5645d770274368a6855af5a7dd
src/scheduler_p.cpp 0d3a44f721ff4d4610bf018add7e7f9512e60254
src/standardcalendaractionmanager.cpp 04711f2439aa7c2be8eea2901edb7671d73471a4
src/utils_p.h acf026fe47d6346437e61d7e2656d88cc81b05ee
src/utils_p.cpp d9eb12d0daaa7eaac4683c1c864d92d507a4f6dd
Diff: https://git.reviewboard.kde.org/r/123373/diff/
Testing
-------
Thanks,
Christian Mollekopf
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list