[Kde-pim] Review Request 123561: kolabchanges: messageviewer [3/4]
Laurent Montel
montel at kde.org
Thu Apr 30 12:16:08 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123561/#review79725
-----------------------------------------------------------
messageviewer/viewer/viewer_p.h (line 663)
<https://git.reviewboard.kde.org/r/123561/#comment54577>
is it possible to put this method const ?
messageviewer/viewer/viewer_p.cpp (line 1355)
<https://git.reviewboard.kde.org/r/123561/#comment54578>
could you inverse logic ?
if (relatedNoteRelation.isValid()) {
} else {
}
=> we avoid to check negative value first
messageviewer/viewer/viewer_p.cpp (line 1588)
<https://git.reviewboard.kde.org/r/123561/#comment54579>
QStringLiteral
messageviewer/viewer/viewer_p.cpp (line 3394)
<https://git.reviewboard.kde.org/r/123561/#comment54580>
show error string here.
- Laurent Montel
On avr. 30, 2015, 9:57 matin, Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123561/
> -----------------------------------------------------------
>
> (Updated avr. 30, 2015, 9:57 matin)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> * create notes from email
> * show close instead of cancel
>
>
> Diffs
> -----
>
> messageviewer/viewer/viewer.h 40ae9fca3f8d03e9f35ded95923fdf8b1b84fc02
> messageviewer/viewer/viewer.cpp 399aacf9818ad8ae823b2bee4768b3b8b863bb55
> messageviewer/viewer/viewer_p.h c6e579b2d998f1a86526c38779b4be9be94b9817
> messageviewer/viewer/viewer_p.cpp fe76710822057599b94ec1a9b4e2366478c855bf
>
> Diff: https://git.reviewboard.kde.org/r/123561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list