[Kde-pim] Review Request 123521: kolab changes: calendersupport

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123521/#review79597
-----------------------------------------------------------



calendarsupport/collectiongeneralpage.cpp (line 183)
<https://git.reviewboard.kde.org/r/123521/#comment54381>

    attr->blockEverything(mBlockAlarmsCheckBox->isChecked())



calendarsupport/kcalprefs.cpp (line 312)
<https://git.reviewboard.kde.org/r/123521/#comment54384>

    use ref here, no need to copy



calendarsupport/kcalprefs.cpp (line 323)
<https://git.reviewboard.kde.org/r/123521/#comment54382>

    missing identation ?



calendarsupport/tagcache.h (line 43)
<https://git.reviewboard.kde.org/r/123521/#comment54385>

    return by const-ref,
    
    and method should be const ?



calendarsupport/utils.h (line 76)
<https://git.reviewboard.kde.org/r/123521/#comment54386>

    Remove spaces after (



calendarsupport/utils.cpp (line 103)
<https://git.reviewboard.kde.org/r/123521/#comment54388>

    staticCast, since we know it contains



calendarsupport/utils.cpp (line 146)
<https://git.reviewboard.kde.org/r/123521/#comment54389>

    staticCast



calendarsupport/utils.cpp (line 167)
<https://git.reviewboard.kde.org/r/123521/#comment54390>

    staticCast


- Sergio Luis Martins


On April 27, 2015, 4:36 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123521/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 4:36 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> CalendarSupport: show displayName if available for collections
> 
> 
> CalenderSupport: handles now also KCalCore::Incidence::Ptr [1/2]
> 
> need for CalendarViews: Get rid of Akonadi::Item in Agendaview [2/2]
> 
> CalendarSupport/KCalPrefs: Store category colors in tags.
> 
> existance of the BlockAlarmAttribute != blocking alarms
> 
> Check if all alarms are blocked, to activate the checkeckbox "block
> reminders locally". Background is, that we have to descide, if an user
> has set this value by his own or not.
> 
> KOLAB: #3731
> 
> 
> Diffs
> -----
> 
>   calendarsupport/utils.cpp 4e65a960139c0ecddb1c1e13d1930de3f441c6d9 
>   calendarsupport/utils.h c5aced2857d9171cb977aadf516e39c212316d73 
>   calendarsupport/collectiongeneralpage.cpp 45cf9e40c477fa5e12b8836c024feb7d40e8f53a 
>   calendarsupport/kcalprefs.cpp 56c4433deecdf92ce93b06cf4dea2909cd83ef9f 
>   calendarsupport/tagcache.h PRE-CREATION 
>   calendarsupport/tagcache.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123521/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/