[Kde-pim] Review Request 123543: kolab changes for incidenceeditor.
Laurent Montel
montel at kde.org
Wed Apr 29 12:47:47 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123543/#review79664
-----------------------------------------------------------
incidenceeditor-ng/attendeecomboboxdelegate.h (line 46)
<https://git.reviewboard.kde.org/r/123543/#comment54460>
explicit
incidenceeditor-ng/attendeecomboboxdelegate.h (line 48)
<https://git.reviewboard.kde.org/r/123543/#comment54461>
Add Q_DECL_OVERRIDE where necessary
incidenceeditor-ng/attendeecomboboxdelegate.h (line 67)
<https://git.reviewboard.kde.org/r/123543/#comment54462>
coding style => "* " => " *"
incidenceeditor-ng/attendeecomboboxdelegate.h (line 78)
<https://git.reviewboard.kde.org/r/123543/#comment54463>
Reorder variable
incidenceeditor-ng/attendeecomboboxdelegate.h (line 84)
<https://git.reviewboard.kde.org/r/123543/#comment54464>
split class in separate files.
add Q_DECL_OVeRRIDE
add explicit
coding style
incidenceeditor-ng/attendeecomboboxdelegate.cpp (line 149)
<https://git.reviewboard.kde.org/r/123543/#comment54465>
coding style
incidenceeditor-ng/attendeecomboboxdelegate.cpp (line 234)
<https://git.reviewboard.kde.org/r/123543/#comment54466>
coding style
incidenceeditor-ng/attendeetablemodel.h (line 64)
<https://git.reviewboard.kde.org/r/123543/#comment54467>
Q_DECL_OVERRIDE
incidenceeditor-ng/attendeetablemodel.h (line 100)
<https://git.reviewboard.kde.org/r/123543/#comment54468>
explicit where it's necessary
incidenceeditor-ng/attendeetablemodel.cpp (line 245)
<https://git.reviewboard.kde.org/r/123543/#comment54469>
add const
incidenceeditor-ng/attendeetablemodel.cpp (line 258)
<https://git.reviewboard.kde.org/r/123543/#comment54470>
add const
incidenceeditor-ng/freebusyitemmodel.cpp (line 139)
<https://git.reviewboard.kde.org/r/123543/#comment54471>
QLiteralString
incidenceeditor-ng/freeperiodmodel.h (line 41)
<https://git.reviewboard.kde.org/r/123543/#comment54472>
don't readd virtual
incidenceeditor-ng/incidenceattendee.cpp (line 339)
<https://git.reviewboard.kde.org/r/123543/#comment54473>
++i
incidenceeditor-ng/incidenceattendee.cpp (line 522)
<https://git.reviewboard.kde.org/r/123543/#comment54474>
++i
incidenceeditor-ng/incidenceattendee.cpp (line 539)
<https://git.reviewboard.kde.org/r/123543/#comment54475>
++i
incidenceeditor-ng/incidenceattendee.cpp (line 550)
<https://git.reviewboard.kde.org/r/123543/#comment54476>
++i
incidenceeditor-ng/incidenceattendee.cpp (line 578)
<https://git.reviewboard.kde.org/r/123543/#comment54477>
++i fix all x++ -> ++x please
incidenceeditor-ng/incidenceattendee.cpp (line 859)
<https://git.reviewboard.kde.org/r/123543/#comment54478>
Perhaps add "const" on method no ?
incidenceeditor-ng/incidencecategories.h (line 43)
<https://git.reviewboard.kde.org/r/123543/#comment54479>
don't readd virtual
=> add Q_DECL_OVERRIDE
incidenceeditor-ng/incidencedialog.h (line 116)
<https://git.reviewboard.kde.org/r/123543/#comment54480>
coding style
incidenceeditor-ng/incidenceresource.cpp (line 43)
<https://git.reviewboard.kde.org/r/123543/#comment54481>
explicit
Q_DECL_OVERRIDE
incidenceeditor-ng/incidenceresource.cpp (line 79)
<https://git.reviewboard.kde.org/r/123543/#comment54482>
QStringLiteral where it's necessary
incidenceeditor-ng/individualmailcomponentfactory.h (line 42)
<https://git.reviewboard.kde.org/r/123543/#comment54483>
Q_SLOTS
incidenceeditor-ng/individualmailcomponentfactory.h (line 90)
<https://git.reviewboard.kde.org/r/123543/#comment54484>
Q_SLOTS
incidenceeditor-ng/individualmailcomponentfactory.h (line 100)
<https://git.reviewboard.kde.org/r/123543/#comment54485>
don't remove q_nullptr
incidenceeditor-ng/individualmailcomponentfactory.cpp (line 89)
<https://git.reviewboard.kde.org/r/123543/#comment54486>
same here
incidenceeditor-ng/individualmailcomponentfactory.cpp (line 108)
<https://git.reviewboard.kde.org/r/123543/#comment54487>
Please readd QStringLiteral where you rechanged to QLatin1String Thanks
incidenceeditor-ng/individualmaildialog.h (line 46)
<https://git.reviewboard.kde.org/r/123543/#comment54488>
Readd Q_NULLPTR where removed
- Laurent Montel
On avr. 28, 2015, 3:56 après-midi, Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123543/
> -----------------------------------------------------------
>
> (Updated avr. 28, 2015, 3:56 après-midi)
>
>
> Review request for KDEPIM, Christian Mollekopf and Sergio Luis Martins.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> * Create Event/Note/Todo of of Event/Todo
> * Added resourcemanagemt
> * The ResourceManager can now ask a LDAP Server for collection and resources that match a queryString.
> * replacing mAttendeeEditor with TableView
> * Moving freebusy model to libkdepim to reuse it for quickview.
> * replaced categories with Akonadi::Tags
> * "send email" in invitation window should not be visible as default
> * Add GENERIC as default new tag type
>
>
> Diffs
> -----
>
> calendarsupport/kcalprefs.kcfg bb13cd11be7c12fc7673541c303f41867a1039a8
> incidenceeditor-ng/attachmenteditdialog.cpp 95a94363216d6eb5f61ba8ded054356aad19ed9b
> incidenceeditor-ng/attendeecomboboxdelegate.h PRE-CREATION
> incidenceeditor-ng/attendeecomboboxdelegate.cpp PRE-CREATION
> incidenceeditor-ng/attendeeeditor.cpp 4094f191565f9aa50b0c0069f92ecbe3fe07f46a
> incidenceeditor-ng/attendeeline.cpp b1d04480d5897d1b74a541e4bbef6361e2dddefb
> incidenceeditor-ng/attendeetablemodel.h PRE-CREATION
> incidenceeditor-ng/attendeetablemodel.cpp PRE-CREATION
> incidenceeditor-ng/autochecktreewidget.cpp 52ec9d6b6bc309b38c89581fb2b75607e477351e
> incidenceeditor-ng/autotests/conflictresolvertest.h 081957e1be1a2052013da5110b8f47dd6e45cf64
> incidenceeditor-ng/autotests/modeltest.cpp c1ec425c5045d06c88a0a3165cad904df5e132a8
> incidenceeditor-ng/autotests/testfreebusyitemmodel.h
> incidenceeditor-ng/autotests/testfreebusyitemmodel.cpp e26182fc39fd3b5d3b9e844b90523260f7630f08
> incidenceeditor-ng/autotests/testfreeperiodmodel.h
> incidenceeditor-ng/autotests/testfreeperiodmodel.cpp e7ffddd583c5e53dcdb0e37e8c5a3e7bed2fc761
> incidenceeditor-ng/categoryeditdialog.cpp 3b3f8fe6ae0832cb0130a3446cc417bb06196282
> incidenceeditor-ng/combinedincidenceeditor.cpp f7b5e9f68d730b7c96a68264e14395ccdc738637
> incidenceeditor-ng/conflictresolver.h 1e51adbb15ff90a7c5cc6cc2a645cafc02722b4d
> incidenceeditor-ng/conflictresolver.cpp c8b5604440e7d7adf03499d59c40b368670dfe2e
> incidenceeditor-ng/dialogdesktop.ui 267de7ab45f1f170cbb7dec751a5cdfee2638a19
> incidenceeditor-ng/editoritemmanager.cpp a514f541e91d341d1f1535f84ca4146361a368ee
> incidenceeditor-ng/freebusyganttproxymodel.cpp ce2d916a3132b2443930a12f315705f005706886
> incidenceeditor-ng/freebusyitem.h a4529193ed749ceeb2ec67b1eb29040bfb3bd610
> incidenceeditor-ng/freebusyitem.cpp 01152cc110436f22042ccc0f4dd72d298926ad91
> incidenceeditor-ng/freebusyitemmodel.h 951cf6b4cd125c7e5346fe538eaf8f244b4d791e
> incidenceeditor-ng/freebusyitemmodel.cpp cae73fae23dd140d7de6a6c86bc57441f9718dc5
> incidenceeditor-ng/freeperiodmodel.h a6bb656b71678f00a0bcda22e6b7defff0c23af6
> incidenceeditor-ng/freeperiodmodel.cpp 65849a48e7ca0bdbf159b56fa84f6d515973e9d9
> incidenceeditor-ng/incidenceattachment.cpp 3823b8e67ad652a1eb378d55308cd50ddd3ac37d
> incidenceeditor-ng/incidenceattendee.h 7f089fb7e99093fc1aca0c5a14b3338cf9507612
> incidenceeditor-ng/incidenceattendee.cpp 3ff1349daf02c63116e6b53e9b8117ecc3da640a
> incidenceeditor-ng/incidencecategories.h dbcd84da474d9356b395bb369cd82143f51438a5
> incidenceeditor-ng/incidencecategories.cpp 33ee790e2fa034eb5a6bfcbe8b5e25d0d7eb2a4a
> incidenceeditor-ng/incidencecompletionpriority.cpp 455f3f7839c5a7e223520c1516a40b22b5e74eca
> incidenceeditor-ng/incidencedatetime.cpp 970eb9b8ebaab812ad5f62c270ba715cf6689bb0
> incidenceeditor-ng/incidencedialog.h a5aa32dd44cdcd4943c9eb1ac4ab3eda6c6c1e80
> incidenceeditor-ng/incidencedialog.cpp 38e877f262e946ed968650b8fcc44f89f3290c60
> incidenceeditor-ng/incidenceeditor-ng.h 70bbc6bae199fa048a676a57160abc796985ffd8
> incidenceeditor-ng/incidenceeditor.cpp 4bbfdf0ff8dd79f43c337c59a8a3f6a72673e51a
> incidenceeditor-ng/incidenceresource.h PRE-CREATION
> incidenceeditor-ng/incidenceresource.cpp PRE-CREATION
> incidenceeditor-ng/incidencesecrecy.cpp 68b1707d10d4788d8bcbd98e78964e3d9b907423
> incidenceeditor-ng/individualmailcomponentfactory.h d51836d27dda9729cadc1d5a1dad6ccfcf641e19
> incidenceeditor-ng/individualmailcomponentfactory.cpp 0ab38ca61381ce343b49671fe1713d6c634284b3
> incidenceeditor-ng/individualmaildialog.h 3d32372bdc8adfc762d4c3ec5ebc1bea693dfd6f
> incidenceeditor-ng/individualmaildialog.cpp f689c885c51d27c7476f6581e743ed674f5ecc89
> incidenceeditor-ng/ldaputils.h PRE-CREATION
> incidenceeditor-ng/ldaputils.cpp PRE-CREATION
> incidenceeditor-ng/opencomposerjob.h 2461e78bc34f8f69b25f0cff6a3a280ea2629073
> incidenceeditor-ng/opencomposerjob.cpp ef61f2d25afea1b043bcbbb0faa83513ceac5f12
> incidenceeditor-ng/resourceitem.h PRE-CREATION
> incidenceeditor-ng/resourceitem.cpp PRE-CREATION
> incidenceeditor-ng/resourcemanagement.h PRE-CREATION
> incidenceeditor-ng/resourcemanagement.cpp PRE-CREATION
> incidenceeditor-ng/resourcemanagement.ui PRE-CREATION
> incidenceeditor-ng/resourcemodel.h PRE-CREATION
> incidenceeditor-ng/resourcemodel.cpp PRE-CREATION
> incidenceeditor-ng/schedulingdialog.h dc0215cc1ede6bc0fd17260aa44d99176bbf6368
> incidenceeditor-ng/schedulingdialog.cpp ec32e4174bd52948af2c4fddcb362439d757b0da
> incidenceeditor-ng/tests/CMakeLists.txt PRE-CREATION
> incidenceeditor-ng/tests/resourcemanagment_gui.cpp PRE-CREATION
> incidenceeditor-ng/visualfreebusywidget.h d008f8d300461ebd0e0c7bb153b911a6ffc134d5
> incidenceeditor-ng/visualfreebusywidget.cpp 98fede6dc82f59db1a467da3458a2dacba2a6892
> korganizer/CMakeLists.txt 1cc701b93d2ac735fbde2ba3ed13cbc917659a23
> korganizer/koeventpopupmenu.h f76ad2b4537a159f20093da004bfc1341b7d72d3
> korganizer/koeventpopupmenu.cpp 572078ec44d0bdf1886c1fd70af8208c628dd219
> korganizer/noteeditdialog.h PRE-CREATION
> korganizer/noteeditdialog.cpp PRE-CREATION
> korganizer/tests/CMakeLists.txt f69cefd0dbfcb7eaa42a9803f614692ff1461638
> korganizer/tests/koeventpopupmenutest.h PRE-CREATION
> korganizer/tests/koeventpopupmenutest.cpp PRE-CREATION
> korganizer/tests/noteeditdialogtest.h PRE-CREATION
> korganizer/tests/noteeditdialogtest.cpp PRE-CREATION
> libkdepim/CMakeLists.txt 271dbd00c5a8b0fd811268c6b1d73f7d9918e374
> libkdepim/freebusymodel/autotests/CMakeLists.txt PRE-CREATION
> libkdepim/freebusymodel/autotests/modeltest.h PRE-CREATION
> libkdepim/freebusymodel/autotests/modeltest.cpp PRE-CREATION
> libkdepim/freebusymodel/freebusycalendar.h PRE-CREATION
> libkdepim/freebusymodel/freebusycalendar.cpp PRE-CREATION
> libkdepim/prefs/kprefsdialog.h 5d823746a42027d1a5be48c728d7ec4de93b4b1a
> libkdepim/prefs/kprefsdialog.cpp e2bac442e1d1669734755a350bf07dfc21b1b0d5
> libkdepim/widgets/tagwidgets.h 5dd5ab446a7867ac4ebaa9ba08cd8ea6ba07acbe
> libkdepim/widgets/tagwidgets.cpp 072c6be7238d2af55860cdf95d9ef7e321b4231f
> mailcommon/tag/tag.cpp a3de9e5634a77cae2676bce2ec85563a169e63be
>
> Diff: https://git.reviewboard.kde.org/r/123543/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list