[Kde-pim] Review Request 123334: Make kmime build on OSX

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123334/#review78834
-----------------------------------------------------------

Ship it!


Thanks, please push after fixing the minor things below


CMakeLists.txt (line 34)
<https://git.reviewboard.kde.org/r/123334/#comment53925>

    add a line above containing set(BOOST_MIN_VERSION "1.49") and use ${BOOST_MIN_VERSION} in the find_package call



KF5MimeConfig.cmake.in (line 5)
<https://git.reviewboard.kde.org/r/123334/#comment53924>

    replace 1.49 with @BOOST_MIN_VERSION@


- Christophe Giboudeaux


On avr. 11, 2015, 8:03 après-midi, Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123334/
> -----------------------------------------------------------
> 
> (Updated avr. 11, 2015, 8:03 après-midi)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kmime
> 
> 
> Description
> -------
> 
> At least here on OSX/CI one needs to tell kmime that it requires boost.
> 
> (Sorry for the whitespace changes, but they came in due to an indendation cleanup.)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 39cd7f3b9ff12f10af12ba4ed50b2c4eb6ae714a 
>   KF5MimeConfig.cmake.in 6b8fc991d9b8d8dc594c53517533a6d4c8c7ef72 
>   src/CMakeLists.txt 85952870bcdd42baad3a1bd32b0951ecb48f7d96 
> 
> Diff: https://git.reviewboard.kde.org/r/123334/diff/
> 
> 
> Testing
> -------
> 
> Built fine on my MacPorts-based OSX/CI.
> 
> Dependent projects
> 
> * kimap
> * kmbox
> 
> now also built fine.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/