[Kde-pim] Review Request 123484: Re-imported modified collectionsearchjob from zanshin to be shared.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123484/#review79438
-----------------------------------------------------------



libkdepim/job/collectionsearchjob.h (line 36)
<https://git.reviewboard.kde.org/r/123484/#comment54277>

    Q_NULLPTR



libkdepim/job/collectionsearchjob.h (line 38)
<https://git.reviewboard.kde.org/r/123484/#comment54278>

    Q_DECL_OVERRIDE



libkdepim/job/collectionsearchjob.cpp (line 28)
<https://git.reviewboard.kde.org/r/123484/#comment54279>

    coding style."QString &search" etc.
    => astyle kdelibs



libkdepim/job/collectionsearchjob.cpp (line 38)
<https://git.reviewboard.kde.org/r/123484/#comment54280>

    QStringLiteral where it's possible



libkdepim/job/collectionsearchjob.cpp (line 52)
<https://git.reviewboard.kde.org/r/123484/#comment54282>

    use libkdepim_debug for debug



libkdepim/job/collectionsearchjob.cpp (line 64)
<https://git.reviewboard.kde.org/r/123484/#comment54283>

    new connect api



libkdepim/job/collectionsearchjob.cpp (line 90)
<https://git.reviewboard.kde.org/r/123484/#comment54284>

    new connect api where it's possible



libkdepim/job/person.h (line 24)
<https://git.reviewboard.kde.org/r/123484/#comment54285>

    libkdepim => KORG_PERSON ?



libkdepim/job/person.h (line 39)
<https://git.reviewboard.kde.org/r/123484/#comment54286>

    bool in last variable
    => reorder variable please



libkdepim/job/personsearchjob.h (line 37)
<https://git.reviewboard.kde.org/r/123484/#comment54287>

    Q_NULLPTR



libkdepim/job/personsearchjob.h (line 40)
<https://git.reviewboard.kde.org/r/123484/#comment54288>

    Q_DECL_OVERRIDE



libkdepim/job/personsearchjob.cpp (line 28)
<https://git.reviewboard.kde.org/r/123484/#comment54289>

    KLocale is necessary ? it's a kdelibs4support



libkdepim/job/personsearchjob.cpp (line 36)
<https://git.reviewboard.kde.org/r/123484/#comment54290>

    new connect api if possible



libkdepim/job/personsearchjob.cpp (line 80)
<https://git.reviewboard.kde.org/r/123484/#comment54291>

    new connect api in all code



libkdepim/job/personsearchjob.cpp (line 128)
<https://git.reviewboard.kde.org/r/123484/#comment54292>

    ! isEmpty()



libkdepim/job/personsearchjob.cpp (line 183)
<https://git.reviewboard.kde.org/r/123484/#comment54293>

    !isEmpty ?


- Laurent Montel


On avr. 24, 2015, 11:09 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123484/
> -----------------------------------------------------------
> 
> (Updated avr. 24, 2015, 11:09 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (cherry picked from commit 30e818f9f6eddb3822f62f1aafabbd39029f1a51)
> 
> Re-importet modified personsearchjob from zanshin.
> 
> (cherry picked from commit 720ea7a504dbf097312fb75fa67313ee321bf15d)
> 
> Use personsearchjob and collectionsearchjob from libkdepim.
> 
> (cherry picked from commit c382227777ac9c8bfa18e3787434dc260a2be862)
> 
> move to frameworks
> 
> 
> Diffs
> -----
> 
>   libkdepim/CMakeLists.txt 271dbd00c5a8b0fd811268c6b1d73f7d9918e374 
>   libkdepim/job/collectionsearchjob.h PRE-CREATION 
>   libkdepim/job/collectionsearchjob.cpp PRE-CREATION 
>   libkdepim/job/person.h PRE-CREATION 
>   libkdepim/job/personsearchjob.h PRE-CREATION 
>   libkdepim/job/personsearchjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/