[Kde-pim] Review Request 123495: Parse Date: field from ticketmaster emails

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123495/#review79528
-----------------------------------------------------------


The patch looks good, but I would recommend to add some more tests for invalid user content.


kmime/kmime_header_parsing.cpp (line 2033)
<https://git.reviewboard.kde.org/r/123495/#comment54335>

    Your current test do not text the new branch of the second part after ":" (it is always 0, what is boring :)
    
    So please add a test for:
    
    "Fri 24 Apr 2015 10:39:15 +02:23"
    
    also make sure that it fails with incorrect values aka:
    
    Fri 24 Apr 2015 10:39:15 +02:23:45
    Fri 24 Apr 2015 10:39:15 +02asdf
    Fri 24 Apr 2015 10:39:15 +02:af
    Your current test do not text the new branch of the second part after ":" (line 2033 ff).
    
    So please add a test for something like:
    
    "Fri 24 Apr 2015 10:39:15 +02:23"
    
    also make sure that it fails with incorrect values aka:
    
    Fri 24 Apr 2015 10:39:15 +02:23:45
    Fri 24 Apr 2015 10:39:15 +02asdf
    Fri 24 Apr 2015 10:39:15 +02:af
    Fri 24 Apr 2015 10:39:15 +in:af



kmime/tests/auto/parsedatetimetest.cpp (line 54)
<https://git.reviewboard.kde.org/r/123495/#comment54331>

    please disable qDebug at default.


- Sandro Knauß


On April 25, 2015, 1:53 nachm., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123495/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 1:53 nachm.)
> 
> 
> Review request for KDEPIM-Libraries, Sandro Knauß, Thomas McGuire, and Allen Winter.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ticketmaster emails have the timezone with a : in the middle
> 
> This is probably mal formed but parsing them is not hard and will make me not panic thinking i didn't receive the email for the tickets i just bought.
> 
> 
> Diffs
> -----
> 
>   kmime/kmime_header_parsing.cpp 1043738 
>   kmime/tests/auto/CMakeLists.txt 7fe677e 
>   kmime/tests/auto/parsedatetimetest.h PRE-CREATION 
>   kmime/tests/auto/parsedatetimetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123495/diff/
> 
> 
> Testing
> -------
> 
> I added a small autotest \o/
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/