[Kde-pim] Review Request 123404: akonadi-search patches from kolab branch

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123404/#review79139
-----------------------------------------------------------

Ship it!


Go ahead. If I notice anything later we can always fix it up.

Also, it's good that tests were also added.

- Vishesh Handa


On April 17, 2015, 4 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123404/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 4 p.m.)
> 
> 
> Review request for KDEPIM and Vishesh Handa.
> 
> 
> Repository: akonadi-search
> 
> 
> Description
> -------
> 
> The patchset you can find under dev/kolab-merge branch.
> 
> Akonadi-Indexer: Collection indexing
> Index that allows to search for collections.
> 
> Fetch EntityDisplayAttribute with ancestors.
> 
> Added boolean field with value.
> 
> Add Search for Invitations,decliend events..
> 
> Only fetch collections to index.
> 
> Avoid the currently very expensive CollectionUpdateJob whenever possible.
> 
> CollectionUpdateJob does a recursive fetch job which is very inefficient currently.
> 
> PimIndexer: setExclusive to receive notifications about non-enabled collections.
> 
> Avoid name clash (at least on MSVC).
> 
> Exclude test on Windows, can't figure out the linking errors, atm.
> 
> Don't print the full query on every search, less debug noise.
> 
> 
> Diffs
> -----
> 
>   agent/CMakeLists.txt 3f948cddad3af7e80e3ab6dc64feb99b98dc65ce 
>   agent/agent.h a5d92d046898ed46f787029768dbd356e664c2a7 
>   agent/agent.cpp 611aa666ae176dfaee761df86edcc5b99c3058ee 
>   agent/autotests/CMakeLists.txt 5a3c975f4bd251d54b146fad1a86f2812c66db63 
>   agent/autotests/collectionquerytest.cpp PRE-CREATION 
>   agent/calendarindexer.h 6349e525422a694eaf097eae8359cd18918159cf 
>   agent/calendarindexer.cpp eb2c57e92665ebc3213b8e64efd45393457f0fbe 
>   agent/collectionindexer.h PRE-CREATION 
>   agent/collectionindexer.cpp PRE-CREATION 
>   agent/collectionupdatejob.h PRE-CREATION 
>   agent/collectionupdatejob.cpp PRE-CREATION 
>   agent/index.h 4dc03ad9b025e6ecea3e91ca66cf71316a4d83a9 
>   agent/index.cpp f276cfc636ab4f1fa4bd386bb91eb3e603e707bb 
>   agent/org.freedesktop.Akonadi.BalooIndexer.xml b3b379d96667ec02783747ba3633962d73edccc6 
>   agent/scheduler.h 18d01dd21c641c917239569b2356a2d0ba773c64 
>   agent/scheduler.cpp 19a6aff598e681b7a74fb82ab6df230f8a2fe283 
>   akonadiplugin/autotests/CMakeLists.txt 88fa0f8fc92419d20d24a060e6e0ea67b1f7bf8f 
>   akonadiplugin/autotests/searchplugintest.cpp 8a0576de6892c3376c653180fa3b9c72284eb9cb 
>   akonadiplugin/searchplugin.cpp c91fe215be3c78edadbffc99107b954b9b533730 
>   lib/CMakeLists.txt 6bd57ce7f6c6f5eb24463943eff27611fa92beba 
>   lib/collectionquery.h PRE-CREATION 
>   lib/collectionquery.cpp PRE-CREATION 
>   lib/resultiterator.h eb0e478d97d911dd9bc3a587fe52c53e9900059b 
>   search/calendar/calendarsearchstore.cpp e9a568c554545bd06a8eed634b38dc0bd9f92456 
>   search/pimsearchstore.h bc9f9811580ebf9d8369382ab6df09a42572fb23 
>   search/pimsearchstore.cpp b4f7cff5be2bbdf7bf120888048e530428121aa6 
> 
> Diff: https://git.reviewboard.kde.org/r/123404/diff/
> 
> 
> Testing
> -------
> 
> compile and run test
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/