[Kde-pim] Review Request 123559: kolabchanges: messageviewer [1/4]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123559/#review79670
-----------------------------------------------------------



messageviewer/autotests/noteedittest.h (line 29)
<https://git.reviewboard.kde.org/r/123559/#comment54495>

    Q_SLOTS



messageviewer/autotests/noteedittest.cpp (line 29)
<https://git.reviewboard.kde.org/r/123559/#comment54496>

    port to qtest.h



messageviewer/autotests/noteedittest.cpp (line 73)
<https://git.reviewboard.kde.org/r/123559/#comment54497>

    QStringLiteral where necessary



messageviewer/autotests/noteedittest.cpp (line 423)
<https://git.reviewboard.kde.org/r/123559/#comment54498>

    Add test when test for "noteedit->text().trimmed()"
    => it can be disable too for this case.



messageviewer/autotests/rendertest.cpp (line 50)
<https://git.reviewboard.kde.org/r/123559/#comment54499>

    "& file" => &file
    
    QStringLiteral



messageviewer/widgets/noteedit.h (line 41)
<https://git.reviewboard.kde.org/r/123559/#comment54500>

    Q_NULLPTR



messageviewer/widgets/noteedit.h (line 74)
<https://git.reviewboard.kde.org/r/123559/#comment54501>

    Use QPushButton 
    KPushButton is deprecated
    => convert all from code


- Laurent Montel


On avr. 29, 2015, 11:59 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123559/
> -----------------------------------------------------------
> 
> (Updated avr. 29, 2015, 11:59 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   messageviewer/widgets/noteedit.cpp PRE-CREATION 
>   messageviewer/widgets/eventedit.cpp 785df977479fb36ffe96cfc8b119bcff597ded0e 
>   messageviewer/autotests/viewertest.cpp dddf105afd0a7a1cc15dc250be6e2dd19c6981f3 
>   messageviewer/autotests/rendertest.cpp 38db7d4929d07d7f4d5dae1a84d9594b510d4fef 
>   messageviewer/autotests/noteedittest.h PRE-CREATION 
>   messageviewer/widgets/noteedit.h PRE-CREATION 
>   messageviewer/autotests/viewertest.h c442f70647a8028c6c9c758dda5c25ea640ea12e 
>   messageviewer/autotests/noteedittest.cpp PRE-CREATION 
>   messageviewer/autotests/eventedittest.cpp c874f99bc4eb529129f7fb2d0e5b13790cb80586 
>   messageviewer/autotests/CMakeLists.txt 4b9f87395c1932ed8e9fee11e2497ef63584436e 
> 
> Diff: https://git.reviewboard.kde.org/r/123559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/