[Kde-pim] Review Request 123571: Added myRights support

[Sandro Knauß]

> On April 30, 2015, 2:34 nachm., Laurent Montel wrote:
> > pimcommon/acl/imapaclattribute.h, line 46
> > <https://git.reviewboard.kde.org/r/123571/diff/3/?file=365236#file365236line46>
> >
> >     Why change return value as Attribute ?
> >     it avoids to make a cast in code as unittest.
> >     
> >     But if it's necessary, so use c++ cast 
> >     static_cast<....>() in unittest and not c cast.
> >     
> >     Thanks.

This version of imapaclAttribute is only a copy of the one in kdepim-runtime. But okay git blame told me that this line is newer in kdepim than kdepim-runtime.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123571/#review79732
-----------------------------------------------------------


On April 30, 2015, 2:22 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123571/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 2:22 nachm.)
> 
> 
> Review request for KDEPIM, Christian Mollekopf and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Moved/merged new version of imapaclattribute with tests from kdepim-runtime:
> resources/shared/singlefileresource/imapaclattribute.*
> 
> 
> Diffs
> -----
> 
>   pimcommon/acl/autotests/imapaclattributetest.h 16862e8fec0f0761e4392ccbe44fff8770bed299 
>   pimcommon/acl/autotests/imapaclattributetest.cpp f715f8a4adeced7252d25022c3008f27910ec89e 
>   pimcommon/acl/imapaclattribute.h f922d6c4a3ae5a88051a5df686c52e6983763dcc 
>   pimcommon/acl/imapaclattribute.cpp df3176a01dc228fa71c429ccdb9ecd4756c0e31b 
> 
> Diff: https://git.reviewboard.kde.org/r/123571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/