[Kde-pim] Review Request 123371: KCalCore patches from kolab branch

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123371/
-----------------------------------------------------------

(Updated April 16, 2015, 1:29 p.m.)


Review request for KDEPIM-Libraries and Laurent Montel.


Repository: kcalcore


Description
-------

Add recurrenceId to OccurenceIterator

The recurrenceId is needed in the case we want to create another
exception.

Conflicts:
	src/occurrenceiterator.cpp

Exceptions with THISANDFUTURE and single exception

Make sure that, if a THISANDFUTURE exception is used, that also after a
single additional exception it falls back to the THISANDFUTURE
exception.

Conflicts:
	src/occurrenceiterator.cpp

workaround for libical #185 (recurrenceid with multiple parameters)

if a recurrenceid has range and tzid parameter than libical read it
like this:

tzid="Europe/Berlin;RANGE=THISANDFUTURE"
range=None

KOLAB: 4835

Added test for recurrenceid with range and tzid parameter

make sure that also a recurrenceid with range and tzid parameter is
written and read correctly.

Mark todo as completed, according to their status

todo can have two ways to indicate, that are completed. Either with 100%
completed and one with the status StatusCompleted.

KOLAB: 4818

Implement support for FBTYPE in VFREEBUSY in KCalCore


KCalCore: event::isMutliDay was never using the cache

mostly it is called with no argument, so spec is invalid

* most of the time was spent in KDateTime.addSecs(-1), it is a realy
  rarce case, that this second is import.

Solution: Test if the second can be important before executiing time
intensive function.

~5% performance boost

ICalFormat: Introduce incidence parsing that ignores timezoneinformation.

This is orders of magnitudes faster when used in the akonadi serializer,
and uses a lot less memory (from 500mb to 100 for 10k events).


Diffs (updated)
-----

  CMakeLists.txt d1d4e92e7b51a0f9ebde0c407a81f5c79e938d84 
  autotests/testoccurrenceiterator.cpp 384e1cf1e01c358680dbccc0ba9d70b46e406140 
  autotests/testreadrecurrenceid.cpp b07cfe8243205d977f9f0c4f5856f1b9f0d2bec7 
  autotests/testtodo.cpp 5b79787a98e3c1578795a9f9bb9724e8561d803d 
  src/event.cpp e481aa442f2a27491774d5b69ce845354e3127bc 
  src/freebusyperiod.h 2ab73617e50753e67699bcae40c3b2f75bbfdf32 
  src/freebusyperiod.cpp b9c9218604c457f0ee84daa3c97b1168d2239fb3 
  src/icalformat.h 2e9ddbbf2a8d18a4dd1bccf54f902b183a89c754 
  src/icalformat.cpp 8eb7b30d217a4bd5ee7654f6642cff7878d2ad8d 
  src/icalformat_p.h 10abe159492bb08ef813ef14d203c00f7b8d95d4 
  src/icalformat_p.cpp e869105631f74565fd813d25827ac243b2b38040 
  src/occurrenceiterator.h a5f9fd13c69a595e05b461197dfca0c133d29943 
  src/occurrenceiterator.cpp 2bbfb43c5cc3f365061f8009dd311d0f57e1f4b6 
  src/todo.cpp 180e388bd6f231d8fe746cb3c965393f1290e929 

Diff: https://git.reviewboard.kde.org/r/123371/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/