[Kde-pim] Review Request 123495: Parse Date: field from ticketmaster emails

[Laurent Montel]

> On avr. 25, 2015, 2:09 après-midi, Laurent Montel wrote:
> > kmime/tests/auto/parsedatetimetest.cpp, line 29
> > <https://git.reviewboard.kde.org/r/123495/diff/1/?file=363047#file363047line29>
> >
> >     Don't use qtest_kde.h please it's kdelibs4support
> 
> Albert Astals Cid wrote:
>     Laurent, this is for kdelibs4-based kdepimlibs, so it should be ok. Once we agree on this one i can port to master or another repo (not sure if kmime has moved)

Oh ! indeed sorry I think that it was for kf5.
So it's agree indeed.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123495/#review79500
-----------------------------------------------------------


On avr. 25, 2015, 1:53 après-midi, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123495/
> -----------------------------------------------------------
> 
> (Updated avr. 25, 2015, 1:53 après-midi)
> 
> 
> Review request for KDEPIM-Libraries, Sandro Knauß, Thomas McGuire, and Allen Winter.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ticketmaster emails have the timezone with a : in the middle
> 
> This is probably mal formed but parsing them is not hard and will make me not panic thinking i didn't receive the email for the tickets i just bought.
> 
> 
> Diffs
> -----
> 
>   kmime/kmime_header_parsing.cpp 1043738 
>   kmime/tests/auto/CMakeLists.txt 7fe677e 
>   kmime/tests/auto/parsedatetimetest.h PRE-CREATION 
>   kmime/tests/auto/parsedatetimetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123495/diff/
> 
> 
> Testing
> -------
> 
> I added a small autotest \o/
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/