[Kde-pim] Review Request 119614: Fix range check for non-recurring events

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119614/#review66163
-----------------------------------------------------------



kontact/plugins/korganizer/tests/summaryeventtest.cpp
<https://git.reviewboard.kde.org/r/119614/#comment46166>

    Please use for your tests the data driven testing. This makes it more easier to read them:
    http://qt-project.org/doc/qt-4.8/qtestlib-tutorial2.html


- Sandro Knauß


On Aug. 13, 2014, 12:27 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119614/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 12:27 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 327256
>     http://bugs.kde.org/show_bug.cgi?id=327256
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The check whether an event is in the selected interval (in SummaryEventInfo::eventsForRange()) is totally broken for non-recurring events.
> This patch should fix it, and also add a unit test.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/tests/summaryeventtest.h a3cbb7e 
>   kontact/plugins/korganizer/tests/summaryeventtest.cpp 892da77 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
> 
> Diff: https://git.reviewboard.kde.org/r/119614/diff/
> 
> 
> Testing
> -------
> 
> Add some appointments (without recurrence) in KOrganizer, they are now shown correctly in Kontact's summary view if they are in the configured interval, and not shown if they are outside that interval.
> 
> Before, only today's events were shown (and recurrent ones), see the bug report.
> 
> Also successfully ran the added unit test, it fails with the original code.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/