[Kde-pim] Review Request 120022: Coding Style for collectionrequester.h conflictresolvedialog_p.h dragdropmanager_p.h entitylistview.h entitytreeview.h etmviewstatesaver.h standardactionmanager.h agentactionmanager.cpp agentinstancewidget.cpp agenttypedialog.cpp agenttypewidget.cpp collectiondialog_desktop.

[Kevin Krammer]

> On Sept. 1, 2014, 9:17 vorm., Kevin Krammer wrote:
> > akonadi/src/widgets/standardactionmanager.cpp, line 125
> > <https://git.reviewboard.kde.org/r/120022/diff/1/?file=308898#file308898line125>
> >
> >     I am not sure we have a rule for this kind of initialization yet, but this will become more common when we start using C++11 initializer lists.
> >     
> >     I guess this reformatting happens because of this being interpreted as a block?
> 
> Guy Maurel wrote:
>     You are right: No, we don't have anything for that.
>     As the lines are long, I think the actual layout is OK.

Yes, we can leave them as they are. since the block rules don't apply and we don't have any new rules yet.
We could ask for opinions on kde-core-devel and check if there is any recommendation in the Qt rules for that


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120022/#review65631
-----------------------------------------------------------


On Sept. 2, 2014, 8:01 vorm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120022/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 8:01 vorm.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/src/widgets/agentactionmanager.cpp 25b5147 
>   akonadi/src/widgets/agentinstancewidget.cpp 82750a4 
>   akonadi/src/widgets/agenttypedialog.cpp 0e94072 
>   akonadi/src/widgets/agenttypewidget.cpp 49e77da 
>   akonadi/src/widgets/collectiondialog_desktop.cpp 8501de4 
>   akonadi/src/widgets/collectionpropertiesdialog.cpp f1ec782 
>   akonadi/src/widgets/collectionpropertiespage.cpp cb30f89 
>   akonadi/src/widgets/collectionrequester.h 82da385 
>   akonadi/src/widgets/collectionrequester.cpp 812dd6b 
>   akonadi/src/widgets/collectionview.cpp 7ac8262 
>   akonadi/src/widgets/conflictresolvedialog.cpp f8082a0 
>   akonadi/src/widgets/conflictresolvedialog_p.h 12b430e 
>   akonadi/src/widgets/dragdropmanager.cpp a2b69ec 
>   akonadi/src/widgets/dragdropmanager_p.h f87be88 
>   akonadi/src/widgets/entitylistview.h bc2ca5d 
>   akonadi/src/widgets/entitytreeview.h dc7d26a 
>   akonadi/src/widgets/entitytreeview.cpp facdb72 
>   akonadi/src/widgets/renamefavoritedialog.cpp 4793739 
>   akonadi/src/widgets/standardactionmanager.h f876d15 
>   akonadi/src/widgets/subscriptiondialog.cpp 96d514a 
>   akonadi/src/widgets/tageditwidget.cpp 5b57755 
>   akonadi/src/widgets/tagmanagementdialog.cpp 4bd7949 
>   akonadi/src/widgets/tagselectiondialog.cpp 91f2e57 
>   akonadi/src/widgets/tagwidget.cpp 38819a6 
>   akonadi/src/widgets/etmviewstatesaver.h abb5194 
>   akonadi/src/widgets/recentcollectionaction.cpp 7026046 
> 
> Diff: https://git.reviewboard.kde.org/r/120022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/