[Kde-pim] Killing kpimutils framework

[Kevin Ottens]

On Monday 29 September 2014 21:20:20 Ingo Klöcker wrote:
> On Monday 29 September 2014 13:42:17 Daniel Vratil wrote:
> > LinkLocator - probably another adept for KCodecs or KCoreAddons -
> > given a text, it can extract all email addresses from it (not using
> > the Email class above), convert text into HTML (stuff like */_ markup
> > and links are converted into HTML entities)  - it also supports
> > converting smileys into inline images using KEmoticons - which again
> > makes it problematic to put it into a Tier 1 framework - we could
> > only remove the smileys support to get rid of that dependency,
> > otherwise I don't know what other framework would be a good home for
> > this class.
> 
> Hmm. This class only makes sense in combination with a message viewer.
> 
> Outside of kdepim* it seems to be used only in two places (of which one
> seems to be dead):
> * /extragear/libs/libkfbapi/libkfbapi/eventinfo.cpp
> 
> I didn't have a look, so I have no idea what to do here and which of its
> many features are actually used.
> 
> 
> * /playground/base/plasma-lionmail/*
> 
> I think lionmail is dead. The last real activity seems to have happened
> 3.5 years ago.
> https://projects.kde.org/projects/playground/base/plasma-lionmail/repository
> /revisions/master/revisions?per_page=100
> 
> 
> From your description the LinkLocator class appears to do at least four
> different things (linkify email addresses, linkify URLs, do */_ markup,
> handle emoticons). In my book this means that this class does at least
> three things too much. It should probably be split into 4 (or more)
> separate classes. Those could then be moved to appropriate places, e.g.
> the emoticon handling clearly seems to belong into KEmoticons.

Lots of very good points. Likely the higher path for that one.
 
Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140930/c6c25c1b/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/