[Kde-pim] Review Request 120061: Fix cursor position when 'Insert signature above quoted text' option is set

[Laurent Montel]

> On sep. 11, 2014, 3:29 matin, Iven Hsu wrote:
> > Ship It!
> 
> Laurent Montel wrote:
>     Yes I still wrote you ship it. But by default it's not you who must write it :)
>     Do you have access ?
>     Do you want that I apply it ?
>     
>     Regards
> 
> Iven Hsu wrote:
>     I know that I've no permission to merge it. Just sent it because there's no update since I pushed revision 3. Could you please review and merge it?

I will do it today or tomorrow morning


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120061/#review66205
-----------------------------------------------------------


On sep. 6, 2014, 8:43 matin, Iven Hsu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120061/
> -----------------------------------------------------------
> 
> (Updated sep. 6, 2014, 8:43 matin)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 211634
>     http://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Cursor position should be before the signature. See:
> https://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Diffs
> -----
> 
>   kpimidentities/signature.h 3a97b95c9e854bcaddbeecbdac6762737ce158dd 
>   kpimidentities/signature.cpp cea2313b95193c3b5ef7377820da355065781321 
>   kpimidentities/tests/signaturetest.cpp 944ce929c764815be7ba8ced171ce5f422794d72 
> 
> Diff: https://git.reviewboard.kde.org/r/120061/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE 4.14.
> 
> 
> Thanks,
> 
> Iven Hsu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/