[Kde-pim] Review Request 120070: Coding Style for attributeentity.cpp attributefactory.cpp changenotificationdependenciesfactory.cpp collection.cpp collectionfetchscope.cpp collectionidentificationattribute.cpp collectionpathresolver.cpp collectionsync.cpp control.cpp dbusconnectionpool.cpp exception.cpp firstrun.cpp gidextractor.

[Guy Maurel]

> On Sept. 11, 2014, 4:20 p.m., Kevin Krammer wrote:
> > akonadi/src/core/attributeentity.cpp, line 25
> > <https://git.reviewboard.kde.org/r/120070/diff/1/?file=309949#file309949line25>
> >
> >     hmm, I think for class definitions the opening brace is on a separate line.
> >     Structs are just classes with public access by default.
> >     Or do we have a special rule for structs?

NO, we don't have any rules.
Having a look to kdesupport/akonadi we can see many variations:
qsqlite/src/sqlite_blocking.cpp:39:struct UnlockNotification {
qsqlite/src/QtSql/private/qobject_p.h:74:struct QSignalSpyCallbackSet
qsqlite/src/QtSql/private/qobject_p.h:413:struct QAbstractDynamicMetaObject;

The today change is made by astyle, which makes a difference between class and struct.
For me it is OK.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120070/#review66263
-----------------------------------------------------------


On Sept. 5, 2014, 7:42 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120070/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 7:42 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/src/core/specialcollectionattribute.cpp 4e34c93 
>   akonadi/src/core/tagfetchscope.cpp 9f58db8 
>   akonadi/src/core/typepluginloader.cpp 8679245 
>   akonadi/src/core/exception.cpp 0edb2e8 
>   akonadi/src/core/firstrun.cpp 6373a98 
>   akonadi/src/core/item.cpp 113aee9 
>   akonadi/src/core/itemmonitor.cpp 4fca829 
>   akonadi/src/core/itemserializer.cpp cc855d6 
>   akonadi/src/core/itemsync.cpp 914fa62 
>   akonadi/src/core/monitor_p.cpp 123a5cc 
>   akonadi/src/core/partfetcher.cpp 3033d83 
>   akonadi/src/core/pastehelper.cpp 397983d 
>   akonadi/src/core/servermanager.cpp 73e73a4 
>   akonadi/src/core/attributeentity.cpp 7ad7539 
>   akonadi/src/core/attributefactory.cpp f28f134 
>   akonadi/src/core/changenotificationdependenciesfactory.cpp 634cc4a 
>   akonadi/src/core/collection.cpp 79c8150 
>   akonadi/src/core/collectionfetchscope.cpp 3000374 
>   akonadi/src/core/collectionidentificationattribute.cpp d6485a0 
>   akonadi/src/core/collectionpathresolver.cpp 1a18094 
>   akonadi/src/core/collectionsync.cpp 4a7a9db 
>   akonadi/src/core/control.cpp 38434e4 
>   akonadi/src/core/dbusconnectionpool.cpp d467659 
> 
> Diff: https://git.reviewboard.kde.org/r/120070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/