[Kde-pim] Review Request 120220: Coding Style for blockalarmsattribute.cpp calendarbase.cpp calendarclipboard.cpp calendarmodel.cpp calfilterproxymodel_p.cpp etmcalendar.cpp fetchjobcalendar.cpp freebusydownloadjob_p.cpp freebusymanager.cpp

[Guy Maurel]

> On Sept. 17, 2014, 2:40 p.m., Kevin Krammer wrote:
> > akonadi-calendar/src/calendarmodel.cpp, line 41
> > <https://git.reviewboard.kde.org/r/120220/diff/1/?file=312425#file312425line41>
> >
> >     hmm, if the : should go in front then the ? should probably as well.
> >     Maybe with one level of intentation so that it is clear that these two lines are part of the same conditional assignment expression.
> >     or leave the : where it is and just intent this line and the one before?

WE don't have any rule for that.
May it would be better to have an if (...) else


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120220/#review66730
-----------------------------------------------------------


On Sept. 15, 2014, 6:33 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120220/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 6:33 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-calendar/src/etmcalendar.cpp 344baa8 
>   akonadi-calendar/src/fetchjobcalendar.cpp 281f612 
>   akonadi-calendar/src/freebusydownloadjob_p.cpp fe669ae 
>   akonadi-calendar/src/freebusymanager.cpp a0c88e2 
>   akonadi-calendar/src/calendarmodel.cpp 9873682 
>   akonadi-calendar/src/calfilterproxymodel_p.cpp 1db1cea 
>   akonadi-calendar/src/blockalarmsattribute.cpp dd8043a 
>   akonadi-calendar/src/calendarbase.cpp 93e2fa8 
>   akonadi-calendar/src/calendarclipboard.cpp 1616790 
> 
> Diff: https://git.reviewboard.kde.org/r/120220/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/