[Kde-pim] Review Request 120268: Coding Style for calendarclipboard.cpp freebusymanager_p.h history.cpp history_p.cpp icalimporter.cpp incidencechanger.cpp itiphandler_p.h mailclient_p.h

[Guy Maurel]

> On Sept. 19, 2014, 11:08 a.m., Kevin Krammer wrote:
> > akonadi-calendar/src/incidencechanger.cpp, line 549
> > <https://git.reviewboard.kde.org/r/120268/diff/1/?file=313256#file313256line549>
> >
> >     maybe move the return into the block, like we do for break?

Yes. I take it.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120268/#review66921
-----------------------------------------------------------


On Sept. 18, 2014, 6:57 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120268/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 6:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-calendar/src/freebusymanager_p.h fad0f7c41e8e05913a63c2e9b1bec02131f1e715 
>   akonadi-calendar/src/calendarclipboard.cpp 1616790 
>   akonadi-calendar/src/itiphandler_p.h aaae4fd8d2c6ecddfca6acc9c0bd0228c99b2f06 
>   akonadi-calendar/src/mailclient_p.h 854cdc3d7a744a26365899f75229ad90746a7470 
>   akonadi-calendar/src/history_p.cpp 2c0418d 
>   akonadi-calendar/src/icalimporter.cpp 77b7863 
>   akonadi-calendar/src/incidencechanger.cpp 01f8d3c 
>   akonadi-calendar/src/history.cpp 34c7136d1486b2abb98a47558baf38f71d26b829 
> 
> Diff: https://git.reviewboard.kde.org/r/120268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/