[Kde-pim] Review Request 119933: Optimize: Share set of \SEEN flag across items.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119933/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 2:49 p.m.)


Review request for KDEPIM-Libraries and David Faure.


Changes
-------

This should now work on GCC/Clang and potentially on Windows in the future, once they properly support C++11 and set `__cplusplus` accordingly.

Is it OK to push this into KDE/4.14?


Repository: kdepimlibs


Description
-------

Most items just have a single \SEEN flag in their list of flags.
Currently, we share the \SEEN flag, but not the list itself. By
special-casing this extremely often occurring case, we can decrease
the memory consumption easily. In my case it's a difference of ca.
7MB (171MB before vs. 164MB after).


Diffs (updated)
-----

  akonadi/protocolhelper.cpp 3d496667fa622cac2dda7d5a0ca4c92b5a59d2fe 

Diff: https://git.reviewboard.kde.org/r/119933/diff/


Testing
-------

ran it before and after this patch and compared the memory consumption. That went down noticeably. Also added a static counter to compare cache hits/misses temporarily, which showed this cache is easily hit ca. 40k times and only missed 4k times (so a 10:1 ratio, not bad at all :))


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/