[Kde-pim] Review Request 120061: Fix cursor position when 'Insert signature above quoted text' option is set

[Laurent Montel]

> On sep. 5, 2014, 6:09 après-midi, Laurent Montel wrote:
> > kpimidentities/signature.h, line 236
> > <https://git.reviewboard.kde.org/r/120061/diff/2/?file=309946#file309946line236>
> >
> >     Why add new line at the start ?
> >     We just need signature at top no ?
> 
> Iven Hsu wrote:
>     I'm not sure how other people use it. For me, when 'Insert signature above quoted text' is selected, I'd like the mail struture to be like this:
>     
>     
>     ```
>     <cursor>
>     
>     -- 
>     Iven
>     Software Engineer
>     XXX Corporation
>     (quoted text)
>     ```
>     
>     So that I can enter the main content immediately at the cursor.
>     
>     If no new lines are added, the mail will be:
>     
>     
>     ```
>     <cursor>-- 
>     Iven
>     Software Engineer
>     XXX Corporation
>     (quoted text)
>     ```
>     
>     People will have to insert new lines themselves.
>     
>     It seem common to add a blank line between the main content and the signature, so I added two new lines before the signature.

Ok seems logical.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120061/#review65848
-----------------------------------------------------------


On sep. 5, 2014, 5:20 après-midi, Iven Hsu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120061/
> -----------------------------------------------------------
> 
> (Updated sep. 5, 2014, 5:20 après-midi)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 211634
>     http://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Cursor position should be before the signature. See:
> https://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Diffs
> -----
> 
>   kpimidentities/signature.h 3a97b95c9e854bcaddbeecbdac6762737ce158dd 
>   kpimidentities/signature.cpp cea2313b95193c3b5ef7377820da355065781321 
>   kpimidentities/tests/signaturetest.cpp 944ce929c764815be7ba8ced171ce5f422794d72 
> 
> Diff: https://git.reviewboard.kde.org/r/120061/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE 4.14.
> 
> 
> Thanks,
> 
> Iven Hsu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/