[Kde-pim] Reproduceable error on imap_resource startup

[David Faure]

On Sunday 28 September 2014 19:52:48 David Faure wrote:
> Today, whenever I start the imap resource and press F5 in a folder, it
> errors out with ResourceTask::onSessionRequested: Cancelling this request.
> Probably there is no more session available
> 
> I debugged it by adding debug output in the imap resource, see diff and log
> attached.
> 
> I think the problem is that it's starting a RetrieveCollectionMetadataTask
> before the RetrieveItemsTask is done.
> 
> I believe this comes from commit c15f671e81b7d6cea9ce668660231dea5120077b
> Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
> Date:   Fri May 2 15:04:12 2014 +0200
> 
>     IMAP-Resource: Always fetch the collection before doing a
> RetrieveCollectionMetadataTask

The relevant diff from that commit is:

--- a/resources/imap/imapresource.cpp
+++ b/resources/imap/imapresource.cpp
@@ -431,7 +431,27 @@ void ImapResource::triggerCollectionExtraInfoJobs( const QVariant &collectionVar
   const Collection collection( collectionVariant.value<Collection>() );
   emit status( AgentBase::Running, i18nc( "@info:status", "Retrieving extra folder information for '%1'", collection.name() ) );
 
-  startTask(new RetrieveCollectionMetadataTask( createResourceState(TaskArguments(collection)), this ));
+  //The collection that we received is potentially outdated.
+  //Using it would overwrite attributes with old values.
+  //FIXME: because this is async and not part of the resourcetask, it can't be killed. ResourceBase should just provide an up-to date copy of the collection.
+  Akonadi::CollectionFetchJob *fetchJob = new Akonadi::CollectionFetchJob(collection, CollectionFetchJob::Base, this);
+  fetchJob->fetchScope().setAncestorRetrieval( CollectionFetchScope::All );
+  fetchJob->fetchScope().setIncludeStatistics( true );
+  connect(fetchJob, SIGNAL(result(KJob*)), this, SLOT(onMetadataCollectionFetchDone(KJob*)));
+}
[...]

Shouldn't that Akonadi::CollectionFetchJob be moved to inside the RetrieveCollectionMetadataTask class?
Then it would use the imap session for that task, rather than a separate one.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/