[Kde-pim] Review Request 120061: Fix cursor position when 'Insert signature above quoted text' option is set

[Iven Hsu]

> On Sept. 5, 2014, 8:07 a.m., Laurent Montel wrote:
> > Hi,
> > Thanks for this patch.
> > But if it's a 4.14 bug why don't create patch for 4.14 ? (after we merge in master).
> > 
> > Could you create an unittest to be sure that it works ?
> > 
> > Thanks.

Thanks. This is my first patch to KDE, and I'm not so familiar with the workflow.

I'll update the patch against 4.14 branch and add an unittest later.


- Iven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120061/#review65818
-----------------------------------------------------------


On Sept. 5, 2014, 7:25 a.m., Iven Hsu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120061/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 7:25 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 211634
>     http://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Cursor position should be before the signature. See:
> https://bugs.kde.org/show_bug.cgi?id=211634
> 
> 
> Diffs
> -----
> 
>   kidentitymanagement/src/signature.h 1625a23b3a95db8a61df656e83f96838f85f6e57 
>   kidentitymanagement/src/signature.cpp 2f0037e9fc24f94706384b0f6481933d06b992f8 
> 
> Diff: https://git.reviewboard.kde.org/r/120061/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE 4.14 branch, and ported the code to master.
> 
> 
> Thanks,
> 
> Iven Hsu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/