[Kde-pim] Review Request 120395: Removed the minimum string length from Kontact quick search

[Wyatt Childers]

> On Sept. 29, 2014, 9:28 a.m., Dan Vrátil wrote:
> > I generally welcome being able to search for three-letter shortcuts (I can't even search for "KDE" now :P), but I think that removing the string length constraint completely is not a good idea. At least one- and two-letter strings should be ignored - that's simply because matching "K" and "KD" will be expensive and will very rarely yield anything useful.
> > 
> > Also, you probably need to adapt messagelist/tests/quicksearchlinetest.cpp to this change, otherwise the test will be failing.
> 
> Laurent Montel wrote:
>     I already done last friday.
>     Please update your source code.
>     And yes correct fix was not to remove all checks :)
>     Regards.

I was thinking about that, however, it seems kind of buggy that the interface doesn't respond. Also, someone legitmately might want to search for something like "BB" in a subject line.


- Wyatt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120395/#review67607
-----------------------------------------------------------


On Sept. 27, 2014, 7:26 p.m., Wyatt Childers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120395/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 7:26 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This fixes an issue where short searches left the application feeling unresponsive. One such example is in the case where you want to search for an abreviation such as "ASL", KMail formerly wouldn't respond. This also fixes a problem where you would search for "ASL " and then remove one character leaving "ASL", the search would then be stuck on "ASL" even if you then after removed the characters, unless you either added the space back then held down backspace, or used the clear button.
> 
> 
> Diffs
> -----
> 
>   messagelist/core/quicksearchline.cpp 596b933eba00b595033b0c0cd57848b2e59ebfd1 
> 
> Diff: https://git.reviewboard.kde.org/r/120395/diff/
> 
> 
> Testing
> -------
> 
> I've tested KMail's quick search with a variety of character lengths, everything functions as it did before, but simply fires with smaller searches.
> 
> 
> Thanks,
> 
> Wyatt Childers
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/