[Kde-pim] Review Request 119614: Fix range check for non-recurring events

[Sandro Knauß]

> On Sept. 10, 2014, 4:06 nachm., Sandro Knauß wrote:
> > Ship It!
> 
> Wolfgang Bauer wrote:
>     Thank you!
>     One question though: Should I commit the fix to master as well, or will this be merged? (and if so, should I merge it myself?)
> 
> Wolfgang Bauer wrote:
>     > One question though: Should I commit the fix to master as well, or will this be merged? (and if so, should I merge it myself?)
>     
>     Ok, forget that question.
>     I noticed that it has been merged to master already.
>     
>     Thanks!

The practice is, that a developer merge from stable to master on their own. But if you forget it, someone other will do it.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119614/#review66187
-----------------------------------------------------------


On Sept. 10, 2014, 7:28 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119614/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 7:28 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 327256
>     http://bugs.kde.org/show_bug.cgi?id=327256
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The check whether an event is in the selected interval (in SummaryEventInfo::eventsForRange()) is totally broken for non-recurring events.
> This patch should fix it, and also add a unit test.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
>   kontact/plugins/korganizer/tests/summaryeventtest.h a3cbb7e 
>   kontact/plugins/korganizer/tests/summaryeventtest.cpp 892da77 
> 
> Diff: https://git.reviewboard.kde.org/r/119614/diff/
> 
> 
> Testing
> -------
> 
> Add some appointments (without recurrence) in KOrganizer, they are now shown correctly in Kontact's summary view if they are in the configured interval, and not shown if they are outside that interval.
> 
> Before, only today's events were shown (and recurrent ones), see the bug report.
> 
> Also successfully ran the added unit test, it fails with the original code.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/