[Kde-pim] Review Request 120230: Fix incorrect ecm_mark_as_test usage

[Alexander Richardson]

> On Sept. 16, 2014, 5:06 nachm., Christophe Giboudeaux wrote:
> > syndication/autotests/CMakeLists.txt, line 11
> > <https://git.reviewboard.kde.org/r/120230/diff/1/?file=312514#file312514line11>
> >
> >     Why ? testlibsyndication is a testing tool.
> >     
> >     The only thing that's wrong is commit d8d274df this executable shouldn't have been moved out of tests/

I assumed it was only useful for unit tests since it is inside a autotests/ subdirectory.
ecm_mark_as_test only makes sure that the target is not build when -DBUILD_TESTING=OFF is passed to cmake.

If it is used for something other than testing that line can be removed.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120230/#review66679
-----------------------------------------------------------


On Sept. 16, 2014, 1:54 nachm., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120230/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 1:54 nachm.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> It is meant to be applied to a target and not a test name
> 
> 
> Diffs
> -----
> 
>   syndication/autotests/CMakeLists.txt fd7f2b614c28ddd245ba8dadb47fbc7f0ce7ed12 
>   akonadi/autotests/CMakeLists.txt d6472fb4d0efbfd7e7aed83d033a6d714b4aafca 
>   akonadi/src/xml/autotests/CMakeLists.txt 6687a82818dadaaaccfd2102c6b79296a70006ad 
>   kioslave/src/smtp/tests/CMakeLists.txt cc38bddb2dc910b4e002be7e3dc7828d36bcb01a 
> 
> Diff: https://git.reviewboard.kde.org/r/120230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/