[Kde-pim] Review Request 117812: Port from QJSON to QtCore JSON classes

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117812/#review66405
-----------------------------------------------------------


Looks good to me, but someone else must approve.

The comments below are just remarks, ignore at will.


akonadi-socialutils/src/serializer/akonadi_serializer_socialfeeditem.cpp
<https://git.reviewboard.kde.org/r/117812/#comment46312>

    not sure if this is possible, but if you can change the API of feedItem, then make it take a QJsonObject instead of a QVariantMap. The conversion from the former to the latter is relatively costly and will copy the contents.



akonadi-socialutils/src/serializer/akonadi_serializer_socialfeeditem.cpp
<https://git.reviewboard.kde.org/r/117812/#comment46313>

    if that API gets changed (see above), the conversion here would also not be required


- Milian Wolff


On Sept. 13, 2014, 12:38 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117812/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 12:38 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Martin Klapetek.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Port akonadi-socialutils from QJSON to QtCore JSON classes
> 
> 
> port away from Q_EXPORT_PLUGIN2
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7a775f8de4c078993809f42777b7eb8e324daca0 
>   akonadi-socialutils/CMakeLists.txt af0d37beaf649c26eba02117f2b13ddfa74dc81d 
>   akonadi-socialutils/cmake/FindQJSON.cmake 9701c81131895bfcae0937cef1dc440578729117 
>   akonadi-socialutils/src/CMakeLists.txt db34d23796418949f19a87cd3fe0cfe2d0e9d6e2 
>   akonadi-socialutils/src/serializer/akonadi_serializer_socialfeeditem.h ac292d39472be237a635355eaaaa1a663a4b8b17 
>   akonadi-socialutils/src/serializer/akonadi_serializer_socialfeeditem.cpp 4816afafbcb68b95023f061b265015b60b8073e2 
>   akonadi/src/core/searchquery.cpp 16c67687ebb682d144294f0c1f2a8dac6263e6fc 
>   akonadi/tests/CMakeLists.txt e2a4e2423c994b1e65fe89fc0a7f93c690688dee 
>   cmake/modules/CMakeLists.txt 2f5b8844c7fb1bb66ab5420b9fb3080f6c96c7a3 
>   cmake/modules/FindQJSON.cmake 9701c81131895bfcae0937cef1dc440578729117 
> 
> Diff: https://git.reviewboard.kde.org/r/117812/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/