[Kde-pim] Review Request 120044: Fix build with Qt version 5.2, regarding QAtomicInteger include
Dan Vrátil
dvratil at redhat.com
Wed Sep 3 10:50:27 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120044/#review65765
-----------------------------------------------------------
Ship it!
Ship it, thanks!
- Dan Vrátil
On Sept. 3, 2014, 9:49 a.m., Casian Andrei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120044/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 9:49 a.m.)
>
>
> Review request for Akonadi and Dan Vrátil.
>
>
> Repository: akonadi
>
>
> Description
> -------
>
> There is an include for QAtomicInteger which does not check the version of Qt. Looks like QAtomicInteger appeared starting with 5.3. Placed a similar #ifdef check to one found in the same file.
>
>
> Diffs
> -----
>
> src/server/storage/storagedebugger.h 537fd74
>
> Diff: https://git.reviewboard.kde.org/r/120044/diff/
>
>
> Testing
> -------
>
> Previously Akonadi did not build with Qt 5.2
> Now it builds fine for me.
>
>
> Thanks,
>
> Casian Andrei
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list