[Kde-pim] Review Request 120117: Coding Style for calendarbasetest.h etmcalendartest.h itiphandlertest.h unittestbase.h etmcalendartest.cpp fetchjobcalendartest.cpp helper.cpp historytest.cpp incidencechangertest.cpp itiphandlertest.cpp mailclienttest.cpp todopurgertest.cpp unittestbase.cpp etmcalendartest.

[Guy Maurel]

> On Sept. 12, 2014, 9:20 a.m., Kevin Krammer wrote:
> > akonadi-calendar/autotests/historytest.cpp, line 326
> > <https://git.reviewboard.kde.org/r/120117/diff/3/?file=311589#file311589line326>
> >
> >     in a previous patch this break had moved into the block, which I think is what we want, no?
> >     Why is this no longer the case? How did fixing the four spaces before comma change this?
> >     I would expect that if I diff revision 1 against the latest, I would have only four changes: the four spaces before comma gone.
> >     If it is not feasible to have all fixes in one change for whatever reason, I would go with the first revision

All correct.
I only change an option for astyle: it works now such as we wanted.
Only the place of break must be done manually. My check-script generate a message for that.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120117/#review66319
-----------------------------------------------------------


On Sept. 11, 2014, 5:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120117/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 5:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-calendar/autotests/calendarbasetest.h 1bd58297fe150bfb2696a2ee62539d4131b2a2a2 
>   akonadi-calendar/autotests/etmcalendartest.h 1bfab95ab89f67ca491e1c7a640ff224068bdbb9 
>   akonadi-calendar/autotests/fetchjobcalendartest.cpp bcbe4ce0700ecadda2d48b60fc3f038d7376ec09 
>   akonadi-calendar/autotests/helper.cpp f191457caa190f579c92ac14213ca2338d4ca4a3 
>   akonadi-calendar/autotests/historytest.cpp d8df4a7ce239033231e31bd4b5e6fe0e122c7f85 
>   akonadi-calendar/autotests/incidencechangertest.cpp 4eff64781a44e6153ae722af88473427b5785a2d 
>   akonadi-calendar/autotests/itiphandlertest.h 8f394b3 
>   akonadi-calendar/autotests/itiphandlertest.cpp f70942674fa4ac370791c36d83c60b299152865b 
>   akonadi-calendar/autotests/mailclienttest.cpp 7b2de7c19e0765afc9570a4e69c1d36399da34e9 
>   akonadi-calendar/autotests/todopurgertest.cpp dc0cc5fc33629130a72440f2bb2fc3dfc63fca86 
>   akonadi-calendar/autotests/unittestbase.h f6dde88616aa9741b66289f453399753db15bfb7 
> 
> Diff: https://git.reviewboard.kde.org/r/120117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/