[Kde-pim] Review Request 120553: FavoriteCollectionsModel: Don't look for new collections everytime the ETM updates a cell and QSPFM re-sorts.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120553/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 8:53 p.m.)


Review request for KDEPIM-Libraries, Christian Mollekopf and Dan Vrátil.


Summary (updated)
-----------------

FavoriteCollectionsModel: Don't look for new collections everytime the ETM updates a cell and QSPFM re-sorts.


Repository: kdepimlibs


Description
-------

(the QSPFM in question is MailCommon::EntityCollectionOrderProxyModel
which has setDynamicSortFilter(true) - I'll investigate why).

But in any case, it seems to me that this is about being notified about
new collections, so purely sorting (which is what layoutChanged is about)
doesn't matter.


Diffs
-----

  akonadi/favoritecollectionsmodel.cpp 7046346bd5a7f5b09bdbc16d85cd81113870dff2 

Diff: https://git.reviewboard.kde.org/r/120553/diff/


Testing
-------


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/