[Kde-pim] Review Request 120668: Port KAbc away from KDELibs4Support

[Aleix Pol Gonzalez]

> On Oct. 20, 2014, 7:16 p.m., Laurent Montel wrote:
> > kabc/src/address.cpp, line 597
> > <https://git.reviewboard.kde.org/r/120668/diff/1/?file=320856#file320856line597>
> >
> >     "kf5_" ?
> >     And 30 lines before it's not kf5_ ?

Yes, this was changed during the port, for co-installability. Also there were 2 sets of files called entry.desktop. Anyway, will look into it tomorrow. Good catch!


> On Oct. 20, 2014, 7:16 p.m., Laurent Montel wrote:
> > kabc/src/addressee.h, line 29
> > <https://git.reviewboard.kde.org/r/120668/diff/1/?file=320857#file320857line29>
> >
> >     Why now it's necessary #include <QMap> ?

Well it's a typedef over a forward declaration. Otherwise it wouldn't build kpeople. Includes may have changed over the switch from Qt4 to Qt 5. I think it's useful to have it. I can drop it, no problem.


> On Oct. 20, 2014, 7:16 p.m., Laurent Montel wrote:
> > kabc/src/errorhandler.cpp, line 77
> > <https://git.reviewboard.kde.org/r/120668/diff/1/?file=320858#file320858line77>
> >
> >     Why ? KMessageBox is not deprecated

I don't think it's worth pulling another dependency on KWidgetsAddons, only for KMessageBox.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120668/#review68770
-----------------------------------------------------------


On Oct. 20, 2014, 3:58 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120668/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 3:58 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Stops linking against KDELibs4Support.
> 
> The weird part is the KLocale port. I think it's correct but I would appreciate some review.
> 
> 
> Diffs
> -----
> 
>   kabc/CMakeLists.txt 5cda2ef 
>   kabc/autotests/addresstest.cpp 29bf722 
>   kabc/src/CMakeLists.txt c54477f 
>   kabc/src/address.cpp 4daf016 
>   kabc/src/addressee.h 48f9093 
>   kabc/src/errorhandler.cpp 4addf4c 
>   kabc/src/vcarddrag.cpp c77a0d9 
> 
> Diff: https://git.reviewboard.kde.org/r/120668/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> Tests pass except for the AddressTest (but it doesn't look related, I can look into it later)
> FAIL!  : AddressTest::formatTest() Compared values are not the same
>    Actual   (address.formattedAddress(QLatin1String("Huck Finn"))): "Huck Finn\n457 Foobar Ave\nNervousbreaktown DC, 1A2B3C\n\nUNITED STATES OF AMERICA"
>    Expected (result)                                              : "Huck Finn\n457 Foobar Ave\nNervousbreaktown,  DC 1A2B3C\n\nUNITED STATES OF AMERICA"
>    Loc: [/home/kde-devel/frameworks/kdepimlibs/kabc/autotests/addresstest.cpp(195)]
> 
> Also KPeople tests work, as well as KPeople itself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/