[Kde-pim] Review Request 120631: CalendarSupport/KCalPrefs: Store category colors in tags.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120631/#review69083
-----------------------------------------------------------


Thanks for implementing this. Can't "ship it" since I don't know the akonadi tag system / API, but I'm glad to see this fixed.

I think this makes CategoryConfig::setColors() and associated code now unused, so that should be removed? No point in keeping dead code around.

- David Faure


On Oct. 17, 2014, 5 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120631/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 5 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This allows resources to synchronize category colors and fixes the category color configuration.
> 
> 
> Diffs
> -----
> 
>   calendarsupport/kcalprefs.h e12c005 
>   calendarsupport/kcalprefs.cpp 559377b 
> 
> Diff: https://git.reviewboard.kde.org/r/120631/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/