[Kde-pim] Review Request 120692: Coding Style for imageprovider.cpp imageprovider.h socialfeeditem.cpp socialfeeditem.h socialnetworkattributes.cpp socialnetworkattributes.h

[Laurent Montel]

> On oct. 22, 2014, 5:28 après-midi, Marc Mutz wrote:
> > Who cares about the review of whitespace if the file contains so many functional issues? :)

Yes indeed.
Marc could you provide a patch for it.
Guy will not able to fix all of them.

Thanks.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120692/#review68931
-----------------------------------------------------------


On oct. 21, 2014, 5:09 après-midi, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120692/
> -----------------------------------------------------------
> 
> (Updated oct. 21, 2014, 5:09 après-midi)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-socialutils/src/imageprovider.h 16c96aa 
>   akonadi-socialutils/src/imageprovider.cpp 430941d 
>   akonadi-socialutils/src/socialfeeditem.h 388e557 
>   akonadi-socialutils/src/socialfeeditem.cpp 67933e4 
>   akonadi-socialutils/src/socialnetworkattributes.h 07c9257 
>   akonadi-socialutils/src/socialnetworkattributes.cpp e8ba3e6 
> 
> Diff: https://git.reviewboard.kde.org/r/120692/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/