[Kde-pim] Review Request 120644: Make BatchFetcher workaround MS Exchange "bugs"

[André Wöbbeking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120644/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 7:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Christian Mollekopf.


Bugs: 339393
    http://bugs.kde.org/show_bug.cgi?id=339393


Repository: kdepim-runtime


Description
-------

If the result of UID SEARCH is too big Exchange just disconnects. To work around this the UID SEARCH is splitted into smaller chunks (I choose 2000 arbitrarily) . First I wanted to do this for all servers but I've a server where UIDs go up to 1 billion which results in half a million SearchJobs. So I do the splitting only for Exchange servers. I don't know if there is a better way to recognize Exchange servers than to look at Session::serverGreeting()?

Cheers,
André


Diffs
-----

  resources/imap/batchfetcher.h 0f8ff2e 
  resources/imap/batchfetcher.cpp 7b9bf9d 
  resources/imap/retrieveitemstask.cpp 6de11bc 

Diff: https://git.reviewboard.kde.org/r/120644/diff/


Testing
-------

- All my IMAP accounts are working fine.
- All IMAP tests pass.


Thanks,

André Wöbbeking

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/