[Kde-pim] Review Request 120470: C++11-narrowing causes Clang to break compilation. static_cast to solve the issue

[Milian Wolff]

> On Oct. 3, 2014, 11:22 a.m., Jan Kundrát wrote:
> > How does it work on these funny platform like Arm with different signedness of char? Would it make sense to use a string literal with \x escapes for each UTF-8/Latin-1 byte?
> 
> Jan Kundrát wrote:
>     Thanks for ignoring my comment -- makes me want to review patches again.</sarcasm>
> 
> Helio Castro wrote:
>     I'm really sorry Jan, i just saw it today after Laurent email. Not my intention, really sorry. Even did wrong process in put shipit instead of submitted.
>     
>     So, i really can't answer this directly, since never tested arm arch for this, even clang. This follows the recommendation on C++ board on this issues, and clang is verty restrictive, thing that gcc is not.
>     Hope someone jump on this and answer better.

Using static cast is fine, it will blow up on arm if it does not work there.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120470/#review67854
-----------------------------------------------------------


On Oct. 6, 2014, 1:38 p.m., Helio Castro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120470/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 1:38 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> C++11-narrowing causes Clang to break compilation. static_cast to solve the issue
> 
> 
> Diffs
> -----
> 
>   plugins/autotests/kcalcoreserializertest.cpp a4a2fca073d889597bc18750993162c35d5bf1b2 
> 
> Diff: https://git.reviewboard.kde.org/r/120470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Helio Castro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/