[Kde-pim] Review Request 120764: Fix KMail mailing list filtering regression

[Laurent Montel]

> On oct. 24, 2014, 10:35 matin, Jean-Baptiste Mardelle wrote:
> > Ship It!

? :)
Why do you "ship it" ?
you are the create of review so you mustn't do it.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120764/#review69085
-----------------------------------------------------------


On oct. 23, 2014, 8:44 après-midi, Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120764/
> -----------------------------------------------------------
> 
> (Updated oct. 23, 2014, 8:44 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 340015
>     http://bugs.kde.org/show_bug.cgi?id=340015
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> A regression was introduced in kdepim 4.14.2 by the fix for bug 339090.
> The problem described in bug 339090 does not seem to involve real mailing lists (with the list-id tag) at least the sample email provided by the reporter does not hold any "list-id" tag in its header.
> 
> The fix breaks mailing list filtering (those that have a "list-id" in it) - as reported in bug 340015, which is in my opinion a much worse problem than what is was supposed to fix.
> 
> My patch makes mailing list filters work again (it only reverts the "list-id" filter to the way it was before), so it should not be a problem.
> 
> I hope someone can have a look at it.
> 
> 
> Diffs
> -----
> 
>   mailcommon/search/searchpattern.cpp f4d32c3 
> 
> Diff: https://git.reviewboard.kde.org/r/120764/diff/
> 
> 
> Testing
> -------
> 
> Filtering on a mailing list works again for me with the patch.
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/