[Kde-pim] Review Request 120865: Coding Style for address.h addressee.h addresseehelper.h addresseelist.h contactgroup.h contactgrouptool.h errorhandler.h field.h geo.h key.h ldifconverter.h phonenumber.h picture.h plugin.h secrecy.h sortmode.h sound.h timezone.h vcardconverter.h vcarddrag.h vcardtool.h

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120865/#review69417
-----------------------------------------------------------



kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120865/#comment48513>

    Should this also have argument name? Same for operator==() and operator!=(), since you added it to the copy ctor?



kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120865/#comment48514>

    c -> category - descriptive names are better :)



kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120865/#comment48515>

    c -> categories



kabc/src/addresseelist.h
<https://git.reviewboard.kde.org/r/120865/#comment48516>

    l -> addreseeList



kabc/src/contactgroup.h
<https://git.reviewboard.kde.org/r/120865/#comment48518>

    Missing argument name



kabc/src/contactgroup.h
<https://git.reviewboard.kde.org/r/120865/#comment48519>

    Missing argument name



kabc/src/field.h
<https://git.reviewboard.kde.org/r/120865/#comment48521>

    a -> addr (or addressee)



kabc/src/field.h
<https://git.reviewboard.kde.org/r/120865/#comment48522>

    a -> addr



kabc/src/field.h
<https://git.reviewboard.kde.org/r/120865/#comment48523>

    a -> addr



kabc/src/geo.h
<https://git.reviewboard.kde.org/r/120865/#comment48524>

    Missing argument name



kabc/src/geo.h
<https://git.reviewboard.kde.org/r/120865/#comment48525>

    Missing argument name



kabc/src/key.h
<https://git.reviewboard.kde.org/r/120865/#comment48526>

    Missing argument name



kabc/src/key.h
<https://git.reviewboard.kde.org/r/120865/#comment48527>

    Missing argument name



kabc/src/phonenumber.h
<https://git.reviewboard.kde.org/r/120865/#comment48528>

    Missing argument name



kabc/src/phonenumber.h
<https://git.reviewboard.kde.org/r/120865/#comment48529>

    Missing argument name



kabc/src/picture.h
<https://git.reviewboard.kde.org/r/120865/#comment48530>

    Missing argument name



kabc/src/picture.h
<https://git.reviewboard.kde.org/r/120865/#comment48531>

    Missing argument name



kabc/src/secrecy.h
<https://git.reviewboard.kde.org/r/120865/#comment48532>

    Missing argument name



kabc/src/secrecy.h
<https://git.reviewboard.kde.org/r/120865/#comment48533>

    Missing argument name



kabc/src/secrecy.h
<https://git.reviewboard.kde.org/r/120865/#comment48534>

    Missing argument name



kabc/src/timezone.h
<https://git.reviewboard.kde.org/r/120865/#comment48535>

    Missing argument name



kabc/src/timezone.h
<https://git.reviewboard.kde.org/r/120865/#comment48536>

    Missing argument name


- Dan Vrátil


On Oct. 28, 2014, 7:19 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120865/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 7:19 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Krammer, Laurent Montel, and Tobias Koenig.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   kabc/src/addresseehelper.h 84dad2a 
>   kabc/src/addresseelist.h 4ffe8db 
>   kabc/src/contactgroup.h 2a7a695 
>   kabc/src/contactgrouptool.h 83c8a91 
>   kabc/src/errorhandler.h 6a421dc 
>   kabc/src/field.h f917868 
>   kabc/src/geo.h 5d67562 
>   kabc/src/key.h 8a1fbb9 
>   kabc/src/ldifconverter.h d12bdbf 
>   kabc/src/phonenumber.h cab5d6b 
>   kabc/src/picture.h 3e9780f 
>   kabc/src/plugin.h 1f9005e 
>   kabc/src/secrecy.h 33108b1 
>   kabc/src/sortmode.h 36be9c8 
>   kabc/src/sound.h 2a7d205 
>   kabc/src/timezone.h 8311c5b 
>   kabc/src/vcardconverter.h 4c19d0f 
>   kabc/src/vcarddrag.h 11e0f4b 
>   kabc/src/vcardtool.h 25a95e5 
>   kabc/src/address.h de079a6 
>   kabc/src/addressee.h baa9e99 
> 
> Diff: https://git.reviewboard.kde.org/r/120865/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/