[Kde-pim] Review Request 120646: Coding Style for abstractcontactformatter.cpp abstractcontactgroupformatter.cpp attributeregistrar.cpp collectionfiltermodel.cpp contactcompletionmodel.cpp contactdefaultactions.cpp contacteditor.cpp contacteditordialog.cpp

Dan Vrátil dvratil at redhat.com
Fri Oct 24 09:15:14 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120646/#review69080
-----------------------------------------------------------



akonadi-contact/src/contactdefaultactions.cpp
<https://git.reviewboard.kde.org/r/120646/#comment48300>

    Fix the coding style in the string too, please - it's a method signature, so it should follow the coding style too.
    
    Also applies to the four string below.


- Dan Vrátil


On Oct. 18, 2014, 5:18 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120646/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2014, 5:18 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-contact/src/abstractcontactformatter.cpp 9eb6efc 
>   akonadi-contact/src/abstractcontactgroupformatter.cpp cf437f0 
>   akonadi-contact/src/attributeregistrar.cpp 0ad3adf 
>   akonadi-contact/src/collectionfiltermodel.cpp cd465ec 
>   akonadi-contact/src/contactcompletionmodel.cpp 31a2a4e 
>   akonadi-contact/src/contactdefaultactions.cpp a1c795b 
>   akonadi-contact/src/contacteditor.cpp a4368c4 
>   akonadi-contact/src/contacteditordialog.cpp 03ab34a 
> 
> Diff: https://git.reviewboard.kde.org/r/120646/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list