[Kde-pim] Review Request 120527: ItemSync/TransactionSquence: Don't abort on error

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120527/#review68191
-----------------------------------------------------------


Thank you! I tested this patch on my real imap account (where I could reliably trigger the problem), and it fixes the problem. The imap resource keeps working after the error happens.


Next problem: getting more info out of "NO Multiple merge candidates, aborting", like UIDs, so I can look into why this happens....

- David Faure


On Oct. 9, 2014, 8:04 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120527/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 8:04 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, David Faure and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemSync/TransactionSquence: Don't abort on error
> 
> The ItemSync must never emit result before it's complete. This patch fixes
> this behvaiour in case of an error on the ItemCreateJob.
> 
> * Adding a job does not reset the status if a rollback was initiated already,
> and thus avoids a second rollback on commit() after one was already performed
> earlier (this resulted in the "No transaction in progress" error message).
> * The rollback job, that is equally added using addSubjob still gets regularly
> executed.
> 
> 
> Diffs
> -----
> 
>   akonadi/tests/itemsynctest.cpp d0b7cee6c4ad3766ad9bb5c6219af5752514511d 
>   akonadi/transactionsequence.cpp 2d6bb7b430ee0b9c004ef02224ec7792a7116370 
> 
> Diff: https://git.reviewboard.kde.org/r/120527/diff/
> 
> 
> Testing
> -------
> 
> Seems to work for me, unittests.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/