[Kde-pim] Review Request 120553: FavoriteCollectionsModel: Don't look for new collections everytime the ETM updates a cell and QSPFM re-sorts.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120553/#review68281
-----------------------------------------------------------


-1 ... some favorite folders don't appear anymore until clicking on them in the foldertree.

I guess insertion into a sorted model can lead to some new rows taking the place of older rows, so layoutChanged is indeed the only way.

- David Faure


On Oct. 11, 2014, 8:57 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120553/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 8:57 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Christian Mollekopf and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> (the QSPFM in question is MailCommon::EntityCollectionOrderProxyModel
> which has setDynamicSortFilter(true) - I'll investigate why).
> 
> But in any case, it seems to me that this is about being notified about
> new collections, so purely sorting (which is what layoutChanged is about)
> doesn't matter.
> 
> 
> Diffs
> -----
> 
>   akonadi/favoritecollectionsmodel.cpp 7046346bd5a7f5b09bdbc16d85cd81113870dff2 
> 
> Diff: https://git.reviewboard.kde.org/r/120553/diff/
> 
> 
> Testing
> -------
> 
> With this and https://git.reviewboard.kde.org/r/120552/ both applied, loading a 13k-emails folder is much much faster here.
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/