[Kde-pim] Review Request 120552: Optimization: skip QSet::toList() conversion just to check for emptiness.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120552/
-----------------------------------------------------------

(Updated Oct. 12, 2014, 2:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Dan Vrátil.


Repository: kdepimlibs


Description
-------

This code is called very often while loading a folder (with threading enabled)

Maybe in frameworks these methods (mimeTypesMonitored etc.) should return QSet
to avoid the conversion altogether?


Diffs
-----

  akonadi/entitytreemodel_p.cpp 8d24973494b78726bdeb4f01990aeab139c4d745 
  akonadi/monitor.h 2fb6bc21bbc84b21ed1c8ae943ecb0cc636db615 
  akonadi/monitor.cpp 2759b3464af4ff082c183ef38576612778c844e0 

Diff: https://git.reviewboard.kde.org/r/120552/diff/


Testing
-------

Between this and https://git.reviewboard.kde.org/r/120553/, loading a 13k-emails folder is much much faster here.


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/