[Kde-pim] Review Request 120647: Coding Style for addressattribute.h messagefolderattribute.h messagemodel.h messagestatus.h messagethreaderproxymodel.h messagethreadingattribute.h removeduplicatesjob.h specialmailcollections.h specialmailcollectionsdiscoveryjob.h specialmailcollectionsrequestjob.h specialmailcollectionstesting_p.

[Dan Vrátil]

> On Oct. 24, 2014, 10:17 a.m., Dan Vrátil wrote:
> > akonadi-mime/src/messagestatus.h, line 63
> > <https://git.reviewboard.kde.org/r/120647/diff/1/?file=320530#file320530line63>
> >
> >     This should be operator= (without the space). The "=" is part of the function name ("operator=") here.
> 
> Guy Maurel wrote:
>     mmmh!
>     These was introduce by Leo Franchi on Jul 29 18:30
>     Isn't it correct such as now?

I guess it is discutable, but the common format is without space after the "operator" keyword (`find -name "*.h" -exec grep -Hn "operator" {} \;`)


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120647/#review69081
-----------------------------------------------------------


On Oct. 18, 2014, 5:27 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120647/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2014, 5:27 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-mime/src/specialmailcollectionstesting_p.h 22dfeb4 
>   akonadi-mime/src/standardmailactionmanager.h 7195501 
>   akonadi-mime/src/messagethreadingattribute.h cb99ccb 
>   akonadi-mime/src/removeduplicatesjob.h 257d8db 
>   akonadi-mime/src/specialmailcollections.h c51ac8d 
>   akonadi-mime/src/specialmailcollectionsdiscoveryjob.h 2341c12 
>   akonadi-mime/src/specialmailcollectionsrequestjob.h 4b7be51 
>   akonadi-mime/src/addressattribute.h 0a66abb 
>   akonadi-mime/src/messagefolderattribute.h d56b318 
>   akonadi-mime/src/messagemodel.h c1ddc16 
>   akonadi-mime/src/messagestatus.h b225721 
>   akonadi-mime/src/messagethreaderproxymodel.h 8c0b742 
> 
> Diff: https://git.reviewboard.kde.org/r/120647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/