[Kde-pim] Review Request 120540: Sieve vacation: add support for date

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120540/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 11:49 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Repository: kdepim


Description
-------

This patch extends Out-of-office reply dialog to allow configuring date range in which the autoreply should be active on the server. This is achieved by generating an additional condition:

    if not allof(currentdate :value "ge" "date" "START-DATE", currentdate :value "le" "date "END-DATE") { keep; stop; }

This feature requires server to support the "date" and "relational" sieve extensions. Otherwise the UI for this will be disabled and the condition won't be inserted into the script.

When none or invalid date is applied, the condition is not generated and the OOO reply is active all the time (like it is now). Thinking about it, having "Specify date range" checkbox that would enable the date edits might be a better approach?


Diffs
-----

  libksieve/ksieveui/vacation/vacationpagewidget.cpp 529ac14 
  libksieve/ksieveui/vacation/vacationscriptextractor.h 9d3ac40 
  libksieve/ksieveui/vacation/vacationutils.h 84b54c8 
  libksieve/ksieveui/vacation/vacationutils.cpp 24accb9 
  libksieve/ksieveui/vacation/vacation.cpp 8702f5c 
  libksieve/ksieveui/vacation/vacationcheckjob.cpp 8eeab6c 
  libksieve/ksieveui/vacation/vacationdialog.h bbb30eb 
  libksieve/ksieveui/vacation/vacationdialog.cpp bbc858f 
  libksieve/ksieveui/vacation/vacationeditwidget.h 71513e3 
  libksieve/ksieveui/vacation/vacationeditwidget.cpp ad8d61e 

Diff: https://git.reviewboard.kde.org/r/120540/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/