[Kde-pim] Review Request 120668: Port KAbc away from KDELibs4Support

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120668/#review68770
-----------------------------------------------------------



kabc/src/address.cpp
<https://git.reviewboard.kde.org/r/120668/#comment48078>

    "kf5_" ?
    And 30 lines before it's not kf5_ ?



kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120668/#comment48077>

    Why now it's necessary #include <QMap> ?



kabc/src/errorhandler.cpp
<https://git.reviewboard.kde.org/r/120668/#comment48079>

    Why ? KMessageBox is not deprecated


- Laurent Montel


On oct. 20, 2014, 3:58 après-midi, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120668/
> -----------------------------------------------------------
> 
> (Updated oct. 20, 2014, 3:58 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Stops linking against KDELibs4Support.
> 
> The weird part is the KLocale port. I think it's correct but I would appreciate some review.
> 
> 
> Diffs
> -----
> 
>   kabc/CMakeLists.txt 5cda2ef 
>   kabc/autotests/addresstest.cpp 29bf722 
>   kabc/src/CMakeLists.txt c54477f 
>   kabc/src/address.cpp 4daf016 
>   kabc/src/addressee.h 48f9093 
>   kabc/src/errorhandler.cpp 4addf4c 
>   kabc/src/vcarddrag.cpp c77a0d9 
> 
> Diff: https://git.reviewboard.kde.org/r/120668/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> Tests pass except for the AddressTest (but it doesn't look related, I can look into it later)
> FAIL!  : AddressTest::formatTest() Compared values are not the same
>    Actual   (address.formattedAddress(QLatin1String("Huck Finn"))): "Huck Finn\n457 Foobar Ave\nNervousbreaktown DC, 1A2B3C\n\nUNITED STATES OF AMERICA"
>    Expected (result)                                              : "Huck Finn\n457 Foobar Ave\nNervousbreaktown,  DC 1A2B3C\n\nUNITED STATES OF AMERICA"
>    Loc: [/home/kde-devel/frameworks/kdepimlibs/kabc/autotests/addresstest.cpp(195)]
> 
> Also KPeople tests work, as well as KPeople itself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/