[Kde-pim] Review Request 120716: Drop QtWidgets dependency in KAbc

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120716/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 10:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Konversation.


Repository: kdepimlibs


Description
-------

It was only used by the GuiErrorHandler, which had a QMessageBox. It didn't seem like a good reason enough to depend on widgets. Especially considering how it's quite a big dependency and will make portability more complex.

Furthermore, lxr.kde.org shows that only Konversation uses it (hence being on the review groups).


Diffs
-----

  kabc/CMakeLists.txt 6b353c8 
  kabc/src/CMakeLists.txt 797a137 
  kabc/src/addresseehelper.cpp 4c8ba15 
  kabc/src/errorhandler.h dbaf51a 
  kabc/src/errorhandler.cpp 620e3ca 

Diff: https://git.reviewboard.kde.org/r/120716/diff/


Testing
-------

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/