[Kde-pim] Review Request 120800: prevent starting a QTimer with a negative interval

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120800/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 11:21 p.m.)


Review request for Akonadi and KDE Software on Mac OS X.


Changes
-------

simplified to use qMax


Repository: akonadi


Description
-------

After waking my Mac from (a night's) sleep, I noticed a quickly repeating error message about starting a QTimer with a negative interval. I could trace this to the PausableTimer instance in collectionscheduler.cpp .
The attached patch prevents the error condition by clipping the calculated remaining time interval to 0 .
I've left a debug statement that can of course doesn't need to be committed.


Diffs (updated)
-----

  server/src/collectionscheduler.cpp 8d4cd5c 

Diff: https://git.reviewboard.kde.org/r/120800/diff/


Testing
-------

On OS X 10.6.8 with kdelibs 4.14.2 and kdepim* 4.13.3


Thanks,

René J.V. Bertin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/