[Kde-pim] Review Request 121035: Move ProgressIndicator{Label, Widget} from KPimUtils to KPIM
Laurent Montel
montel at kde.org
Fri Nov 7 17:15:02 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121035/#review70012
-----------------------------------------------------------
Ship it!
Seems good for me.
Ship it.
- Laurent Montel
On nov. 7, 2014, 4:20 après-midi, Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121035/
> -----------------------------------------------------------
>
> (Updated nov. 7, 2014, 4:20 après-midi)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> This patch import ProgressIndicator{Label,Widget} classes from KPimUtils framework in kdepimlibs to KPIM library in kdepim, and makes all kdepim components build against these copies.
>
> I'll remove the classes from kdepimlibs once this is merged.
>
> This is the second step to kill KPimUtils :)
>
>
> Diffs
> -----
>
> accountwizard/CMakeLists.txt 89e9a8a
> accountwizard/ui/personaldatapage.ui a09e431
> libkdepim/CMakeLists.txt a4f00b9
> libkdepim/ldap/ldapsearchdialog.cpp 951a50e
> libkdepim/widgets/progressindicatorlabel.h PRE-CREATION
> libkdepim/widgets/progressindicatorlabel.cpp PRE-CREATION
> libkdepim/widgets/progressindicatorwidget.h PRE-CREATION
> libkdepim/widgets/progressindicatorwidget.cpp PRE-CREATION
> messageviewer/adblock/adblockshowlistdialog.h 1a6a996
> messageviewer/adblock/adblockshowlistdialog.cpp 3d71ee2
> messageviewer/adblock/tests/adblockblockableitemdialog_gui.h bfe0c16
> messageviewer/adblock/tests/adblockblockableitemdialog_gui.cpp 73db989
> pimcommon/shorturl/shorturlwidget.h f3cbe81
> pimcommon/shorturl/shorturlwidget.cpp 2dc0122
> pimcommon/translator/translatorwidget.cpp 4ca2bbb
>
> Diff: https://git.reviewboard.kde.org/r/121035/diff/
>
>
> Testing
> -------
>
> Builds.
>
>
> Thanks,
>
> Dan Vrátil
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list